Make IF_SVE_FZ_2A and IF_SVE_HG_2A consistent with similar groups #100089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sistent with other groups with similar operands
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
dotnet-policy-service
bot
added
the
community-contribution
|
@a74nh @kunalspathak @dotnet/arm64-contrib @TIHan |
kunalspathak
approved these changes
Mar 21, 2024
|
cc: @TIHan |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the FZ_2A and HG_2A groups that take source registers in the form
{Zn1 - Zn2}take in an even numbered register asZn1and setZn2 = Zn1 +1. This makes it consistent with some other groups of this form, for these groups I have also added assertions thatZn1is even where necessary.