Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Security.Cryptography.Csp.Tests fail on Android #50580

Closed
2 tasks
mdh1418 opened this issue Apr 1, 2021 · 5 comments · Fixed by #56573
Closed
2 tasks

System.Security.Cryptography.Csp.Tests fail on Android #50580

mdh1418 opened this issue Apr 1, 2021 · 5 comments · Fixed by #56573
Labels
area-System.Security os-android
Milestone
6.0.0

Comments

@mdh1418
Copy link
Member

mdh1418 commented Apr 1, 2021 •
edited by steveisok
Loading

Several tests from System.Security.Cryptography.Csp.Tests fail on Android

  • System.Security.Cryptography.Dsa.Tests.DSAKeyGeneration.GenerateSecondMinKey
  • System.Security.Cryptography.Dsa.Tests.DSAKeyGeneration.GenerateMinKey

Based on CI runs from #50095
@mdh1418 mdh1418 added this to the 6.0.0 milestone Apr 1, 2021
@ghost
Copy link

ghost commented Apr 1, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Several tests from System.Security.Cryptography.Csp.Tests fail on Android

  • System.Security.Cryptography.Dsa.Tests.DSAKeyGeneration.GenerateSecondMinKey
  • System.Security.Cryptography.Dsa.Tests.DSAKeyGeneration.GenerateMinKey
  • System.Security.Cryptography.Rsa.Tests.RSAXml.FromNonsenseXml

Based on CI runs from #50095

Author: mdh1418
Assignees: -
Labels:

area-System.Security, os-android
Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 1, 2021
@filipnavara
Copy link
Member

@jkoritzinsky Do you remember if the DSA support on Android has some limitation other than key size >= 1024?

@filipnavara
Copy link
Member

Nevermind, I suspect the DSA tests were fixed by #50192.

@jkoritzinsky
Copy link
Member

I think the key size >=1024 is the only limitation.

@filipnavara
Copy link
Member

Thanks for confirmation. Given the timeline of the test run and the fix I tend to believe the DSA was actually fixed one day after the test run.

@steveisok steveisok removed the untriaged New issue has not been triaged by the area owner label Jun 29, 2021
steveisok pushed a commit to steveisok/runtime that referenced this issue Jul 29, 2021
Enable skipped SSC.Algorithms tests on Andorid
b80aafd 
DSAKeyGeneration.GenerateSecondMinKey and DSAKeyGeneration.GenerateMinKey no longer fail.  Added validation in RSAAndroid.cs to make RSAXml.FromNonsenseXml pass.

Fixes dotnet#50580
Fixes dotnet#50581
@steveisok steveisok mentioned this issue Jul 29, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 29, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 30, 2021
steveisok added a commit that referenced this issue Jul 30, 2021
@steveisok
Enable skipped SSC.Algorithms tests on Andorid (#56573)
b2e483e 
DSAKeyGeneration.GenerateSecondMinKey and DSAKeyGeneration.GenerateMinKey no longer fail. Added validation in RSAAndroid.cs to make RSAXml.FromNonsenseXml pass.

Fixes #50580
Fixes #50581
@ghost ghost locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Security os-android
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Enable skipped SSC.Algorithms tests on Andorid steveisok/runtime
4 participants
@steveisok @jkoritzinsky @filipnavara @mdh1418