Make DSACryptoServiceProvider set legal key sizes to most restrictive for platform #50192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThe legal key sizes for DSA are more restrictive than on other platforms. Update cc @jkoritzinsky @steveisok @AaronRobinsonMSFT @bartonjs
|
jkoritzinsky
approved these changes
Mar 24, 2021
AaronRobinsonMSFT
approved these changes
Mar 24, 2021
steveisok
reviewed
Mar 24, 2021
| { | ||
| key.KeySize = 576; | ||
| } | ||
| catch (CryptographicException) when (PlatformDetection.IsAndroid) |
There was a problem hiding this comment.
Exception filters are problematic in AOT scenarios. I would move this check inside the catch block.
There was a problem hiding this comment.
Yes, we send all assemblies in a suite's publish directory, for example, to the AOT compiler.
bartonjs
reviewed
Mar 24, 2021
....Security.Cryptography.Csp/src/System/Security/Cryptography/DSACryptoServiceProvider.Unix.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 24, 2021
....Security.Cryptography.Csp/src/System/Security/Cryptography/DSACryptoServiceProvider.Unix.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 24, 2021
....Security.Cryptography.Csp/src/System/Security/Cryptography/DSACryptoServiceProvider.Unix.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Mar 24, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legal key sizes for DSA are more restrictive than on other platforms. Update
DSACryptoServiceProviderto use the most restrictive sizes as the legal key sizes.cc @jkoritzinsky @steveisok @AaronRobinsonMSFT @bartonjs