Build fails with MSB3073 if there are spaces in the path

[Tyrrrz]

OS: Windows 10
Head: 46bc2ab4d

If you clone the repository to a directory that has spaces in the path, the build will fail 5-15 minutes in with error code MSB3073: The command "ilasm..." exited with code 9009.

A few lines before that it actually says Could not find a part of the path ... with the full path truncated at the occurrence of the whitespace.

It seems this issue was also reported almost 4 years ago in dotnet/corefx#451 and seemingly fixed but I can reproduce it on the latest master as of the time of writing.

At the very least, it would be nice to mention this in the installation instructions.

[danmoseley]

Hi @Tyrrrz I guess almost everyone working on the repo has no spaces in their path, so it regresses, then someone notices and it fixes, ..

We'd be happy to take a PR, if you're interested.

I suspect it is actually in this file, which is in another repo and we consume via Nuget

https://github.com/dotnet/coreclr/blob/833493193a849311b56026303bec2eaf11eb7d67/src/.nuget/Microsoft.NET.Sdk.IL/targets/Microsoft.NET.Sdk.IL.targets#L135

<Exec Command="$(_IlasmDir)ilasm $(_IlasmSwitches) $(_OutputTypeArgument) $(IlasmFlags) -OUTPUT=&quot;@(IntermediateAssembly)&quot; $(_KeyFileArgument) @(Compile, ' ')">
should probably be
<Exec Command="&quot;$(_IlasmDir)ilasm&quot; $(_IlasmSwitches) $(_OutputTypeArgument) $(IlasmFlags) -OUTPUT=&quot;@(IntermediateAssembly)&quot; $(_KeyFileArgument) @(Compile, ' ')">

[Tyrrrz]

Thanks for the insight, I will take a look at that file and see how I can substitute the targets to test it out.

[Tyrrrz]

It actually turned out there are multiple instances of unquoted paths in the target file, besides the one you pointed out. I have fixed them one by one and it builds successfully now. Will submit a PR shortly.

[stephentoub]

Fix reverted in dotnet/coreclr#27793

[logiclrd]

Can confirm this is still happening.