Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@Tyrrrz
Copy link

@Tyrrrz Tyrrrz commented Nov 6, 2019

Fixes #27699

This fixes issues when running build.cmd in dotnet/corefx when there are spaces on the path.
Fixes #27699
@dnfclas
Copy link

dnfclas commented Nov 6, 2019

CLA assistant check
All CLA requirements met.

@danmoseley
Copy link
Member

Thanks! When you manually patch your machine with this file, does it successfully build corefx for you in your path with spaces?

@Tyrrrz
Copy link
Author

Tyrrrz commented Nov 6, 2019

Yeah it does. Basically that's how I've debugged it and found these issues.

@maryamariyan
Copy link

Thank you for your contribution. As announced in dotnet/coreclr#27549 this repository will be moving to dotnet/runtime on November 13. If you would like to continue working on this PR after this date, the easiest way to move the change to dotnet/runtime is:

  1. In your coreclr repository clone, create patch by running git format-patch origin
  2. In your runtime repository clone, apply the patch by running git apply --directory src/coreclr <path to the patch created in step 1>

@Tyrrrz
Copy link
Author

Tyrrrz commented Nov 6, 2019

@maryamariyan is there a chance it will get merged before then? :)

@jkotas jkotas merged commit d153122 into dotnet:master Nov 7, 2019
@jkotas
Copy link
Member

jkotas commented Nov 7, 2019

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails with MSB3073 if there are spaces in the path

6 participants