[5.0] Fix RCS1263 and RCS1139 for C# 14 extension block XmlDoc - #1799
Merged
Conversation
josefpihrt
commented
Aug 11, 2026
josefpihrt
left a comment
josefpihrt
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review notes for the C# 14 extension-block XmlDoc fixes. Looks correct for #1752; one small follow-up on coverage.
josefpihrt
changed the title
Fixes #1752 Handle ExtensionBlockDeclaration in CSharpUtility parameter and type-parameter resolution, and skip RCS1139 summary requirement on extension block documentation comments. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
josefpihrt
force-pushed
the
fix/analyzers/extension-block-xml-doc
branch
from
August 16, 2026 13:54
c16035b to
60453e7
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 21, 2026
Open
Open
This was referenced Aug 24, 2026
Open
Open
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<param>and<typeparam>references in RCS1263 by handlingSyntaxKind.ExtensionBlockDeclarationinCSharpUtility.GetParameterList/GetTypeParameterListStacked on #1787 (
feature/roslyn-5).Fixes #1752
Test plan
dotnet test Tests/Analyzers.Tests/Analyzers.Tests.csproj --filter "ExtensionBlock"dotnet buildwithRoslynVersion=roslyn5.0,roslyn4.7, androslyn3.8NuGet slicesMade with Cursor