test(analyzers): cover RCS1263 primary constructor params with spaced lists - #1803
Closed
josefpihrt wants to merge 5 commits into
Closed
test(analyzers): cover RCS1263 primary constructor params with spaced lists#1803josefpihrt wants to merge 5 commits into
josefpihrt wants to merge 5 commits into
Conversation
josefpihrt
commented
Aug 11, 2026
josefpihrt
left a comment
josefpihrt
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review notes for RCS1263 primary-constructor param resolution. Ancestor walk is the right fix for #1730; one likely-dead branch to tidy.
Fixes #1730 Resolve the declaring syntax for documentation comments by walking ancestor nodes instead of using parent.Parent, so primary constructor parameters are matched correctly. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
ExtensionBlockDeclarationSyntax already matches MemberDeclarationSyntax. Co-authored-by: Cursor <cursoragent@cursor.com>
josefpihrt
force-pushed
the
fix/analyzers/rcs1263-primary-constructor-param
branch
from
August 14, 2026 20:15
5647b49 to
89d09b7
Compare
josefpihrt
changed the base branch from
fix/analyzers/extension-block-xml-doc
to
main
August 14, 2026 20:16
Co-authored-by: Cursor <cursoragent@cursor.com>
Primary constructor param refs already resolve via GetParameterList. Keep the spaced-parameter-list coverage from #1730. Co-authored-by: Cursor <cursoragent@cursor.com>
josefpihrt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
record struct RS ( int par ),class C ( int prop ))CSharpUtility.GetParameterList(TypeDeclarationSyntax.ParameterList); no analyzer lookup changeFixes #1730
Test plan
dotnet test src/Tests/Analyzers.Tests/Analyzers.Tests.csproj --filter "FullyQualifiedName~RCS1263"