Fix type hierarchy request test compilation - #85253
Merged
Merged
Conversation
Remove properties that are no longer part of the subtype and supertype request models after the LSP 3.18 protocol update. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5eafba01-dc3d-4db4-8343-3cc70b399bba
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
jasonmalinowski
approved these changes
Sep 10, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No blocking issues were identified in the reviewed changes.
Review tier: Lite
Findings: None
What changed in this PR
Fixes type hierarchy test compilation for the LSP 3.18 request model.
Changes:
- Removes obsolete
TextDocumentandPositionassignments. - Preserves document resolution through
Item.Data.
| File | Summary |
|---|---|
src/Razor/src/Razor/test/Microsoft.CodeAnalysis.Razor.CohostingShared.UnitTests/Endpoints/CohostTypeHierarchyEndpointTest.cs |
Updates Razor type hierarchy requests. |
src/LanguageServer/ProtocolUnitTests/TypeHierarchy/TypeHierarchyTests.cs |
Updates language server type hierarchy requests. |
JoeRobich
enabled auto-merge (squash)
September 10, 2026 20:23
akhera99
approved these changes
Sep 10, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the test compilation failures introduced by #82294.
TypeHierarchySupertypesParamsandTypeHierarchySubtypesParamsno longer inheritTextDocumentPositionParamsunder the LSP 3.18 model. Remove the staleTextDocumentandPositionassignments from the Language Server and Razor test requests; the handlers resolve the document fromItem.Data.Validation:
dotnet test src/LanguageServer/ProtocolUnitTests/Microsoft.CodeAnalysis.LanguageServer.Protocol.UnitTests.csproj -f net10.0 --filter 'FullyQualifiedName~TypeHierarchyTests' -p:RunAnalyzersDuringBuild=true --no-restoredotnet test src/Razor/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.UnitTests/Microsoft.VisualStudioCode.RazorExtension.UnitTests.csproj --filter 'FullyQualifiedName~CohostTypeHierarchyEndpointTest' -p:RunAnalyzersDuringBuild=true --no-restoreThe
net472build could not be run locally on macOS because the .NET Framework 4.7.2 targeting pack is unavailable; CI covers that target.Microsoft Reviewers: Open in CodeFlow