LSP 3.18 protocol updates - #82294
Merged
Merged
Conversation
JoeRobich
commented
Feb 19, 2026
| /// </summary> | ||
| [JsonPropertyName("trace")] | ||
| [DefaultValue(typeof(TraceSetting), "off")] | ||
| [DefaultValue(typeof(TraceValue), "off")] |
Member
Author
There was a problem hiding this comment.
We had TraceValue and TraceSetting. They are now unified as TraceValue
dibarbet
approved these changes
Sep 10, 2026
JoeRobich
added a commit
that referenced
this pull request
Sep 10, 2026
Fixes the test compilation failures introduced by #82294. `TypeHierarchySupertypesParams` and `TypeHierarchySubtypesParams` no longer inherit `TextDocumentPositionParams` under the LSP 3.18 model. Remove the stale `TextDocument` and `Position` assignments from the Language Server and Razor test requests; the handlers resolve the document from `Item.Data`. Validation: - `dotnet test src/LanguageServer/ProtocolUnitTests/Microsoft.CodeAnalysis.LanguageServer.Protocol.UnitTests.csproj -f net10.0 --filter 'FullyQualifiedName~TypeHierarchyTests' -p:RunAnalyzersDuringBuild=true --no-restore` - `dotnet test src/Razor/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.UnitTests/Microsoft.VisualStudioCode.RazorExtension.UnitTests.csproj --filter 'FullyQualifiedName~CohostTypeHierarchyEndpointTest' -p:RunAnalyzersDuringBuild=true --no-restore` The `net472` build could not be run locally on macOS because the .NET Framework 4.7.2 targeting pack is unavailable; CI covers that target. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/roslyn/pull/85253) Copilot-Session: 5eafba01-dc3d-4db4-8343-3cc70b399bba
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.