Skip to content

Relax a couple of asserts #81726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlekseyTs merged 1 commit into from
Dec 17, 2025
Merged

Relax a couple of asserts #81726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Compilers/CSharp/Portable/Lowering/AsyncRewriter/AsyncMethodToStateMachineRewriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ private BoundBlock GenerateAwaitForIncompleteTask(LocalSymbol awaiterTemp, Bound

if (!TypeSymbol.Equals(awaiterFieldType, awaiterTemp.Type, TypeCompareKind.ConsiderEverything2))
{
Debug.Assert(awaiterFieldType.IsObjectType());
Debug.Assert(awaiterFieldType.IsObjectType() || TypeSymbol.Equals(awaiterFieldType, awaiterTempRef.Type, TypeCompareKind.AllIgnoreOptions));
Copy link
Member

@jjonescz jjonescz Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test?

Copy link
Contributor Author

@AlekseyTs AlekseyTs Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test?

Theoretically it can be done, but I prefer to not spend time on that in context of this PR. Especially that the change doesn't affect the behavior. The fact that there is a follow up pending for a type comparison is "recorded" by TypeCompareKind.ConsiderEverything2 on the previous line. Most likely, we should be using TypeCompareKind.AllIgnoreOptions there, but I prefer to avoid introducing any potential behavior changes in this PR.

Copy link
Member

@jjonescz jjonescz Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks.

Conversion c = F.ClassifyEmitConversion(awaiterTempRef, awaiterFieldType);
Debug.Assert(c.IsImplicit);
Debug.Assert(c.IsReference || c.IsIdentity);
Expand Down Expand Up @@ -533,7 +533,7 @@ private BoundBlock GenerateAwaitForIncompleteTask(LocalSymbol awaiterTemp, Bound

if (!TypeSymbol.Equals(awaiterTemp.Type, awaiterField.Type, TypeCompareKind.ConsiderEverything2))
{
Debug.Assert(awaiterFieldRef.Type.IsObjectType());
Debug.Assert(awaiterFieldRef.Type.IsObjectType() || TypeSymbol.Equals(awaiterTemp.Type, awaiterFieldRef.Type, TypeCompareKind.AllIgnoreOptions));
Conversion c = F.ClassifyEmitConversion(awaiterFieldRef, awaiterTemp.Type);
Debug.Assert(c.IsReference || c.IsIdentity);
awaiterFieldRef = F.Convert(awaiterTemp.Type, awaiterFieldRef, c);
Expand Down