Merged
Conversation
333fred
approved these changes
Dec 16, 2025
jjonescz
approved these changes
Dec 17, 2025
jjonescz
reviewed
Dec 17, 2025
| if (!TypeSymbol.Equals(awaiterFieldType, awaiterTemp.Type, TypeCompareKind.ConsiderEverything2)) | ||
| { | ||
| Debug.Assert(awaiterFieldType.IsObjectType()); | ||
| Debug.Assert(awaiterFieldType.IsObjectType() || TypeSymbol.Equals(awaiterFieldType, awaiterTempRef.Type, TypeCompareKind.AllIgnoreOptions)); |
Contributor
Author
There was a problem hiding this comment.
Can we add a test?
Theoretically it can be done, but I prefer to not spend time on that in context of this PR. Especially that the change doesn't affect the behavior. The fact that there is a follow up pending for a type comparison is "recorded" by TypeCompareKind.ConsiderEverything2 on the previous line. Most likely, we should be using TypeCompareKind.AllIgnoreOptions there, but I prefer to avoid introducing any potential behavior changes in this PR.
This was referenced Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #81695