Skip to content

Conversation

@CyrusNajmabadi
Copy link
Member

This reverts commit 1a8bea9.

TypeScript uses this API (unfortunately, not through EA). So we can't take this yet.

@jjonescz
Copy link
Member

Shouldn't this target release/dev18.0?

@CyrusNajmabadi
Copy link
Member Author

Shouldn't this target release/dev18.0?

Did we snap.. Then yes. I'll do both. And i'll let infra merge.

@CyrusNajmabadi CyrusNajmabadi changed the title Revert "Use immutable types in signature help (#80322)" Main: Revert "Use immutable types in signature help (#80322)" Sep 23, 2025
@CyrusNajmabadi
Copy link
Member Author

@jjonescz here is d18 version: #80426

Will let infra choose which to take and the merging directions.

@phil-allen-msft phil-allen-msft self-requested a review September 23, 2025 17:54
@akhera99 akhera99 merged commit b4f64f4 into dotnet:main Sep 23, 2025
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 23, 2025
@CyrusNajmabadi CyrusNajmabadi deleted the revertSigHelp branch December 1, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants