Use immutable types in signature help #80322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@dotnet/roslyn-ide this is ready for review |
JoeRobich
approved these changes
Sep 17, 2025
auto-merge was automatically disabled
September 17, 2025 13:56
Rebase failed
auto-merge was automatically disabled
September 17, 2025 14:56
Rebase failed
This was referenced Sep 19, 2025
CyrusNajmabadi
added a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
Sep 23, 2025
This reverts commit 1a8bea9.
CyrusNajmabadi
added a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
Sep 23, 2025
This reverts commit 1a8bea9.
akhera99
pushed a commit
that referenced
this pull request
Sep 23, 2025
Right now we have an issue where users are getting broken MEF compositions cached on their machines, so subsequent launches of the product are operating on a broken composition. It's not "broken" in the sense that "the cache cannot be loaded" but rather the content of the cache is just missing most of our MEF parts. As a defense-in- depth change to deal with potential transient issues, let's not cache compositions we know are bad. Co-authored-by: Jason Malinowski <[email protected]>
akhera99
pushed a commit
that referenced
this pull request
Sep 23, 2025
This was referenced Sep 25, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #80321.