Skip to content

Use immutable types in signature help #80322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyrusNajmabadi merged 21 commits into from
Sep 17, 2025
Merged

Use immutable types in signature help #80322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4a320f6
Cleanup hierarchy
CyrusNajmabadi Sep 17, 2025
e431972
Add tests
CyrusNajmabadi Sep 17, 2025
50538b6
move to immutable types in signature help
CyrusNajmabadi Sep 17, 2025
4aafc8a
move to immutable types in signature help
CyrusNajmabadi Sep 17, 2025
2a08cb6
move to immutable types in signature help
CyrusNajmabadi Sep 17, 2025
8a2d3df
move to immutable types in signature help
CyrusNajmabadi Sep 17, 2025
19a9f5c
move to immutable types in signature help
CyrusNajmabadi Sep 17, 2025
975b9ee
move to immutable types in signature help
CyrusNajmabadi Sep 17, 2025
6f86cbb
move to immutable types in signature help
CyrusNajmabadi Sep 17, 2025
416da2b
move to immutable types in signature help
CyrusNajmabadi Sep 17, 2025
f576b13
move to immutable types in signature help
CyrusNajmabadi Sep 17, 2025
3e7aa9c
move to immutable types in signature help
CyrusNajmabadi Sep 17, 2025
a985f75
move to immutable types in signature help
CyrusNajmabadi Sep 17, 2025
dac6a4f
Simplify tests
CyrusNajmabadi Sep 17, 2025
1d94bb9
Simplify tests
CyrusNajmabadi Sep 17, 2025
818811c
Revert
CyrusNajmabadi Sep 17, 2025
9d9f14c
Update tests
CyrusNajmabadi Sep 17, 2025
d8e28ca
Update tests
CyrusNajmabadi Sep 17, 2025
af767e1
Fix
CyrusNajmabadi Sep 17, 2025
e176343
Merge branch 'main' into sigHelpImmutable
CyrusNajmabadi Sep 17, 2025
665c25e
Merge branch 'main' into sigHelpImmutable
CyrusNajmabadi Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 21 additions & 58 deletions src/EditorFeatures/CSharpTest/SignatureHelp/AttributeSignatureHelpProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ internal override Type GetSignatureHelpProviderType()
[Fact]
public async Task TestInvocationWithoutParameters()
{
var expectedOrderedItems = new List<SignatureHelpTestItem>
{
new("SomethingAttribute()", string.Empty, null, currentParameterIndex: 0)
};

await TestAsync("""
class SomethingAttribute : System.Attribute
{
Expand All @@ -40,17 +35,13 @@ class SomethingAttribute : System.Attribute
class D
{
}
""", expectedOrderedItems);
""",
[new("SomethingAttribute()", string.Empty, null, currentParameterIndex: 0)]);
}

[Fact]
public async Task TestInvocationWithoutParametersMethodXmlComments()
{
var expectedOrderedItems = new List<SignatureHelpTestItem>
{
new("SomethingAttribute()", "Summary For Attribute", null, currentParameterIndex: 0)
};

await TestAsync("""
class SomethingAttribute : System.Attribute
{
Expand All @@ -62,18 +53,13 @@ public SomethingAttribute() { }
class D
{
}
""", expectedOrderedItems);
""",
[new("SomethingAttribute()", "Summary For Attribute", null, currentParameterIndex: 0)]);
}

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/25830")]
public async Task PickCorrectOverload_PickInt()
{
var expectedOrderedItems = new List<SignatureHelpTestItem>
{
new("SomethingAttribute(int i)", currentParameterIndex: 0, isSelected: true),
new("SomethingAttribute(string i)", currentParameterIndex: 0),
};

await TestAsync("""
class SomethingAttribute : System.Attribute
{
Expand All @@ -83,18 +69,14 @@ class SomethingAttribute : System.Attribute
}
[[|Something(i: 1$$|])]
class D { }
""", expectedOrderedItems);
""", [
new("SomethingAttribute(int i)", currentParameterIndex: 0, isSelected: true),
new("SomethingAttribute(string i)", currentParameterIndex: 0)]);
}

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/25830")]
public async Task PickCorrectOverload_PickString()
{
var expectedOrderedItems = new List<SignatureHelpTestItem>
{
new("SomethingAttribute(int i)", currentParameterIndex: 0),
new("SomethingAttribute(string i)", currentParameterIndex: 0, isSelected: true),
};

await TestAsync("""
class SomethingAttribute : System.Attribute
{
Expand All @@ -104,17 +86,14 @@ class SomethingAttribute : System.Attribute
}
[[|Something(i: null$$|])]
class D { }
""", expectedOrderedItems);
""", [
new("SomethingAttribute(int i)", currentParameterIndex: 0),
new("SomethingAttribute(string i)", currentParameterIndex: 0, isSelected: true)]);
}

[Fact]
public async Task TestInvocationWithParametersOn1()
{
var expectedOrderedItems = new List<SignatureHelpTestItem>
{
new("SomethingAttribute(int someInteger, string someString)", string.Empty, string.Empty, currentParameterIndex: 0)
};

await TestAsync("""
class SomethingAttribute : System.Attribute
{
Expand All @@ -125,17 +104,13 @@ public SomethingAttribute(int someInteger, string someString) { }
class D
{
}
""", expectedOrderedItems);
""",
[new("SomethingAttribute(int someInteger, string someString)", string.Empty, string.Empty, currentParameterIndex: 0)]);
}

[Fact]
public async Task TestInvocationWithParametersXmlCommentsOn1()
{
var expectedOrderedItems = new List<SignatureHelpTestItem>
{
new("SomethingAttribute(int someInteger, string someString)", "Summary For Attribute", "Param someInteger", currentParameterIndex: 0)
};

await TestAsync("""
class SomethingAttribute : System.Attribute
{
Expand All @@ -151,17 +126,13 @@ public SomethingAttribute(int someInteger, string someString) { }
|]class D
{
}
""", expectedOrderedItems);
""",
[new("SomethingAttribute(int someInteger, string someString)", "Summary For Attribute", "Param someInteger", currentParameterIndex: 0)]);
}

[Fact]
public async Task TestInvocationWithParametersOn2()
{
var expectedOrderedItems = new List<SignatureHelpTestItem>
{
new("SomethingAttribute(int someInteger, string someString)", string.Empty, string.Empty, currentParameterIndex: 1)
};

await TestAsync("""
class SomethingAttribute : System.Attribute
{
Expand All @@ -172,17 +143,13 @@ public SomethingAttribute(int someInteger, string someString) { }
class D
{
}
""", expectedOrderedItems);
""",
[new("SomethingAttribute(int someInteger, string someString)", string.Empty, string.Empty, currentParameterIndex: 1)]);
}

[Fact]
public async Task TestInvocationWithParametersXmlComentsOn2()
{
var expectedOrderedItems = new List<SignatureHelpTestItem>
{
new("SomethingAttribute(int someInteger, string someString)", "Summary For Attribute", "Param someString", currentParameterIndex: 1)
};

await TestAsync("""
class SomethingAttribute : System.Attribute
{
Expand All @@ -198,17 +165,13 @@ public SomethingAttribute(int someInteger, string someString) { }
|]class D
{
}
""", expectedOrderedItems);
""",
[new("SomethingAttribute(int someInteger, string someString)", "Summary For Attribute", "Param someString", currentParameterIndex: 1)]);
}

[Fact]
public async Task TestInvocationWithClosingParen()
{
var expectedOrderedItems = new List<SignatureHelpTestItem>
{
new("SomethingAttribute()", string.Empty, null, currentParameterIndex: 0)
};

await TestAsync("""
class SomethingAttribute : System.Attribute
{ }
Expand All @@ -217,7 +180,8 @@ class SomethingAttribute : System.Attribute
class D
{
}
""", expectedOrderedItems);
""",
[new("SomethingAttribute()", string.Empty, null, currentParameterIndex: 0)]);
}

[Fact]
Expand Down Expand Up @@ -997,7 +961,6 @@ public Task InvokedWithNoToken()
[Fact, WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/1081535")]
public async Task TestInvocationWithBadParameterList()
{
var expectedOrderedItems = new List<SignatureHelpTestItem>();
await TestAsync("""
class SomethingAttribute : System.Attribute
{
Expand All @@ -1007,6 +970,6 @@ class SomethingAttribute : System.Attribute
class D
{
}
""", expectedOrderedItems);
""", []);
}
}
Loading
Loading