Skip to content

Fix creating skeleton cross-language references #79576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

Fix creating skeleton cross-language references #79576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Workspaces/Core/Portable/TemporaryStorage/TrivialTemporaryStorageService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ private TrivialTemporaryStorageService()

public ITemporaryStorageStreamHandle WriteToTemporaryStorage(Stream stream, CancellationToken cancellationToken)
{
stream.Position = 0;
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there's a bug here, i'm curious how any VB to C# (or vice versa) tests pass today :)

Copy link
Member Author

@jjonescz jjonescz Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point me to such tests? I can investigate

Copy link
Member

@CyrusNajmabadi CyrusNajmabadi Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. like TestGotoDefinitionCrossLanguage. If skeletons aren't working, it's uncelar how the VB project could even know about the C# symbol in order to properly go to def to it.

Copy link
Member Author

@jjonescz jjonescz Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugging through the test on Linux, I can definitely see the diagnostic error BC31519: '{0}' cannot be referenced because it is not a valid assembly. being there, I guess the test just doesn't verify diagnostics. I'm not sure how the go-to-def then works, I guess it doesn't really need the metadata reference, but works differently under the hood?

var newStream = new MemoryStream();
stream.CopyTo(newStream);
return new StreamStorage(newStream);
Expand Down
14 changes: 14 additions & 0 deletions src/Workspaces/CoreTest/WorkspaceTests/AdhocWorkspaceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,4 +592,18 @@ public void TestNotGCRootedOnConstruction()
// rooted within the export provider instance.
GC.KeepAlive(exportProvider);
}

[Fact]
public async Task VbReferencingCSharp()
{
var workspace = new AdhocWorkspace();
var csProj = workspace.AddProject("CsProj", LanguageNames.CSharp);
csProj = csProj.WithCompilationOptions(csProj.CompilationOptions.WithOutputKind(OutputKind.DynamicallyLinkedLibrary));
var vbProj = csProj.Solution.AddProject("VbProj", "VbProj", LanguageNames.VisualBasic)
.AddProjectReference(new ProjectReference(csProj.Id));
vbProj = vbProj.WithCompilationOptions(vbProj.CompilationOptions.WithOutputKind(OutputKind.DynamicallyLinkedLibrary));
var comp = (await vbProj.GetCompilationAsync())!;
var diagnostics = comp.GetDiagnostics();
Assert.Empty(diagnostics);
}
}
Loading