Fix creating skeleton cross-language references #79576
Conversation
|
|
||
| public ITemporaryStorageStreamHandle WriteToTemporaryStorage(Stream stream, CancellationToken cancellationToken) | ||
| { | ||
| stream.Position = 0; |
There was a problem hiding this comment.
if there's a bug here, i'm curious how any VB to C# (or vice versa) tests pass today :)
There was a problem hiding this comment.
Can you point me to such tests? I can investigate
There was a problem hiding this comment.
Sure. like TestGotoDefinitionCrossLanguage. If skeletons aren't working, it's uncelar how the VB project could even know about the C# symbol in order to properly go to def to it.
There was a problem hiding this comment.
Debugging through the test on Linux, I can definitely see the diagnostic error BC31519: '{0}' cannot be referenced because it is not a valid assembly. being there, I guess the test just doesn't verify diagnostics. I'm not sure how the go-to-def then works, I guess it doesn't really need the metadata reference, but works differently under the hood?
To bring in dotnet/roslyn#79576.
* Handle extension members by 'make member static' * Suppress warning introduced by Roslyn bump * Suppress warning in test * Update tests * Update Roslyn To bring in dotnet/roslyn#79571. * Update Roslyn To bring in dotnet/roslyn#79576.
* Handle extension members by 'make member static' * Suppress warning introduced by Roslyn bump * Suppress warning in test * Update tests * Update Roslyn To bring in dotnet/roslyn#79571. * Update Roslyn To bring in dotnet/roslyn#79576.
3 participants
Fixes failures discovered when updating Roslyn in dotnet/roslyn-analyzers#7739.