Skip to content

Add Enum.IsDefined refactoring #78597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyrusNajmabadi merged 7 commits into from
May 20, 2025
Merged

Add Enum.IsDefined refactoring #78597

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
92d5b5b
Remove 'Opt' suffixes
DoctorKrolic May 15, 2025
11701ac
Unify resource strings for special case checks
DoctorKrolic May 15, 2025
0cecaa1
Implement `Enum.IsDefined` check refactoring
DoctorKrolic May 15, 2025
9363160
Simplify equivalence keys
DoctorKrolic May 19, 2025
643e447
Make refactoring resilient against absence of `InvalidEnumArgumentExc…
DoctorKrolic May 19, 2025
736bcc4
Fix formatting
DoctorKrolic May 19, 2025
7e21b01
Simplify
DoctorKrolic May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
401 changes: 390 additions & 11 deletions src/EditorFeatures/CSharpTest/CodeActions/InitializeParameter/AddParameterCheckTests.cs
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 3 additions & 6 deletions src/Features/Core/Portable/FeaturesResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,12 +923,6 @@ This version used in: {2}</value>
<data name="Add_null_check" xml:space="preserve">
<value>Add null check</value>
</data>
<data name="Add_string_IsNullOrEmpty_check" xml:space="preserve">
<value>Add 'string.IsNullOrEmpty' check</value>
</data>
<data name="Add_string_IsNullOrWhiteSpace_check" xml:space="preserve">
<value>Add 'string.IsNullOrWhiteSpace' check</value>
</data>
<data name="Create_and_assign_field_0" xml:space="preserve">
<value>Create and assign field '{0}'</value>
</data>
Expand Down Expand Up @@ -3229,4 +3223,7 @@ Zero-width positive lookbehind assertions are typically used at the beginning of
<data name="Multiple_handlers_found_for_message_0" xml:space="preserve">
<value>Multiple handlers found for message {0}.</value>
</data>
<data name="Add_0_check" xml:space="preserve">
<value>Add '{0}' check</value>
</data>
</root>
232 changes: 192 additions & 40 deletions ...res/Core/Portable/InitializeParameter/AbstractAddParameterCheckCodeRefactoringProvider.cs
View file
Open in desktop

Large diffs are not rendered by default.

15 changes: 5 additions & 10 deletions src/Features/Core/Portable/xlf/FeaturesResources.cs.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions src/Features/Core/Portable/xlf/FeaturesResources.de.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions src/Features/Core/Portable/xlf/FeaturesResources.es.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions src/Features/Core/Portable/xlf/FeaturesResources.fr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions src/Features/Core/Portable/xlf/FeaturesResources.it.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions src/Features/Core/Portable/xlf/FeaturesResources.ja.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions src/Features/Core/Portable/xlf/FeaturesResources.ko.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions src/Features/Core/Portable/xlf/FeaturesResources.pl.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions src/Features/Core/Portable/xlf/FeaturesResources.pt-BR.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions src/Features/Core/Portable/xlf/FeaturesResources.ru.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions src/Features/Core/Portable/xlf/FeaturesResources.tr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions src/Features/Core/Portable/xlf/FeaturesResources.zh-Hans.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading