Skip to content

Add Enum.IsDefined refactoring #78597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyrusNajmabadi merged 7 commits into from
May 20, 2025
Merged

Add Enum.IsDefined refactoring #78597

CyrusNajmabadi merged 7 commits into from
May 20, 2025

Conversation

@DoctorKrolic
Copy link
Contributor

@DoctorKrolic DoctorKrolic commented May 15, 2025

Closes #66327

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner May 15, 2025 18:23
@dotnet-policy-service dotnet-policy-service bot added Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode labels May 15, 2025
@build-analysis build-analysis bot mentioned this pull request May 19, 2025
Closed
3 tasks
@DoctorKrolic
Copy link
Contributor Author

DoctorKrolic commented May 20, 2025

@CyrusNajmabadi Please merge)

@CyrusNajmabadi CyrusNajmabadi merged commit d541659 into dotnet:main May 20, 2025
25 checks passed
@CyrusNajmabadi
Copy link
Member

CyrusNajmabadi commented May 20, 2025

Thanks!

@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 20, 2025
@DoctorKrolic DoctorKrolic deleted the enum-is-defined-parameter-check branch May 20, 2025 15:59
This was referenced May 25, 2025
Closed
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jun 4, 2025
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@CyrusNajmabadi CyrusNajmabadi Awaiting requested review from CyrusNajmabadi

Assignees

No one assigned

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode

Projects

None yet

Milestone

18.0 P1

Development

Successfully merging this pull request may close these issues.

Suggestion: Allow auto-generated Enum.IsDefined parameter checks, similar to the current "Add null check" for reference types

3 participants

@DoctorKrolic @CyrusNajmabadi @RikkiGibson