Skip to content

Update EA contract for Implement with Copilot #77706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maryamariyan wants to merge 2 commits into from
Closed

Update EA contract for Implement with Copilot #77706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f6cfcb
Update EA contract for Implement with Copilot
maryamariyan Mar 20, 2025
8227c72
Test no longer needed
maryamariyan Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 0 additions & 65 deletions src/Features/CSharpTest/Copilot/CSharpImplementNotImplementedExceptionFixProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,71 +410,6 @@ public interface IDataService
.RunAsync();
}

[Fact]
public async Task HandleInvalidCode_SuggestsAsComment()
{
await new CustomCompositionCSharpTest
{
CodeFixTestBehaviors = CodeFixTestBehaviors.FixOne,
TestCode = """
using System;

class C
{
void M()
{
{|IDE3000:throw new NotImplementedException();|}
}
}
""",
FixedCode = """
using System;

class C
{
/* The generated implementation isn't a valid method or property:
using System;
class C
{
void M()
{
throw new NotImplementedException();
}
} */
void M()
{
{|IDE3000:throw new NotImplementedException();|}
}
}
""",
FixedState =
{
MarkupHandling = MarkupMode.Allow,
},
LanguageVersion = LanguageVersion.CSharp11,
ReferenceAssemblies = ReferenceAssemblies.Net.Net60,
}
.WithMockCopilotService(copilotService =>
{
var replacement = """
using System;
class C
{
void M()
{
throw new NotImplementedException();
}
}
""";
copilotService.PrepareUsingSingleFakeResult = new()
{
ReplacementNode = SyntaxFactory.ParseCompilationUnit(replacement),
Message = $"The generated implementation isn't a valid method or property:{Environment.NewLine}{replacement}",
};
})
.RunAsync();
}

[Fact]
public async Task ReplacementNode_Null_NotifiesWithComment()
{
Expand Down
6 changes: 4 additions & 2 deletions src/Features/Core/Portable/Copilot/ImplementationDetails.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Microsoft.CodeAnalysis.CSharp.Syntax;
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not ok. you are referencing C# specific code in a common library. Note: i'm actually surrpised this compiled.


namespace Microsoft.CodeAnalysis.Copilot;

/// <summary>
Expand All @@ -16,7 +18,7 @@ internal sealed class ImplementationDetails
public string? Message { get; init; }

/// <summary>
/// Gets the replacement syntax node. Either this property or <see cref="Message"/> must be set.
/// Gets the replacement node. Either this property or <see cref="Message"/> must be set.
/// </summary>
public SyntaxNode? ReplacementNode { get; init; }
public MemberDeclarationSyntax? ReplacementNode { get; init; }
}
4 changes: 3 additions & 1 deletion src/Features/ExternalAccess/Copilot/GenerateImplementation/ImplementationDetailsWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Microsoft.CodeAnalysis.CSharp.Syntax;

namespace Microsoft.CodeAnalysis.ExternalAccess.Copilot.GenerateImplementation;

/// <summary>
Expand All @@ -18,5 +20,5 @@ internal sealed class ImplementationDetailsWrapper
/// <summary>
/// Gets the replacement syntax node. Either this property or <see cref="Message"/> must be set.
/// </summary>
public SyntaxNode? ReplacementNode { get; init; }
public MemberDeclarationSyntax? ReplacementNode { get; init; }
}
2 changes: 1 addition & 1 deletion src/Features/ExternalAccess/Copilot/InternalAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Microsoft.CodeAnalysis.ExternalAccess.Copilot.GenerateImplementation.Implementat
Microsoft.CodeAnalysis.ExternalAccess.Copilot.GenerateImplementation.ImplementationDetailsWrapper.ImplementationDetailsWrapper() -> void
Microsoft.CodeAnalysis.ExternalAccess.Copilot.GenerateImplementation.ImplementationDetailsWrapper.Message.get -> string?
Microsoft.CodeAnalysis.ExternalAccess.Copilot.GenerateImplementation.ImplementationDetailsWrapper.Message.init -> void
Microsoft.CodeAnalysis.ExternalAccess.Copilot.GenerateImplementation.ImplementationDetailsWrapper.ReplacementNode.get -> Microsoft.CodeAnalysis.SyntaxNode?
Microsoft.CodeAnalysis.ExternalAccess.Copilot.GenerateImplementation.ImplementationDetailsWrapper.ReplacementNode.get -> Microsoft.CodeAnalysis.CSharp.Syntax.MemberDeclarationSyntax?
Microsoft.CodeAnalysis.ExternalAccess.Copilot.GenerateImplementation.ImplementationDetailsWrapper.ReplacementNode.init -> void
Microsoft.CodeAnalysis.ExternalAccess.Copilot.IExternalCSharpCopilotCodeAnalysisService
Microsoft.CodeAnalysis.ExternalAccess.Copilot.IExternalCSharpCopilotCodeAnalysisService.AnalyzeDocumentAsync(Microsoft.CodeAnalysis.Document! document, Microsoft.CodeAnalysis.Text.TextSpan? span, string! promptTitle, System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.Task<System.Collections.Immutable.ImmutableArray<Microsoft.CodeAnalysis.Diagnostic!>>!
Expand Down
Loading