Update EA contract for Implement with Copilot
#77706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes type safety more strict and accurate for ImplementationDetails
ghost
added
Area-IDE
untriaged
maryamariyan
changed the title
Implement with Copilot
akhera99
approved these changes
Mar 20, 2025
dotnet-policy-service
bot
added
Community
Won't be possible to fit non-MemberDeclarationSyntax into replacement node
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using Microsoft.CodeAnalysis.CSharp.Syntax; |
Member
There was a problem hiding this comment.
this is not ok. you are referencing C# specific code in a common library. Note: i'm actually surrpised this compiled.
Merged
Contributor
Author
|
closing, this PR is no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes type safety more strict and accurate for ImplementationDetails