Skip to content

Move suppressions to code instead of .gdnsuppress #74467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjonescz merged 3 commits into from
Jul 22, 2024
Merged

Move suppressions to code instead of .gdnsuppress #74467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9c2d2f
Move suppressions to code instead of .gdnsuppress
akoeplinger Jul 19, 2024
eaad884
Fix formatting
akoeplinger Jul 19, 2024
9e5e4f6
Fix missing newlines
akoeplinger Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions eng/build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,11 @@ function GetIbcSourceBranchName() {
}

function GetIbcDropName() {
[Diagnostics.CodeAnalysis.SuppressMessageAttribute(
'PSAvoidUsingConvertToSecureStringWithPlainText',
'',
Justification='$officialVisualStudioDropAccessToken is a script parameter so it needs to be plain text')]
param()

if ($officialIbcDrop -and $officialIbcDrop -ne "default"){
return $officialIbcDrop
Expand Down
41 changes: 0 additions & 41 deletions eng/config/guardian/.gdnsuppress
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion src/EditorFeatures/CSharpTest2/EmbeddedLanguages/Json/CSharpJsonParserTests_BasicTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4204,7 +4204,12 @@ public void TestOctal6()
<OpenBracketToken>[</OpenBracketToken>
<Sequence>
<Literal>
<NumberToken>07777777777777777777777777777777</NumberToken>

""" +
// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="this is not a credential")]
" <NumberToken>07777777777777777777777777777777</NumberToken>" +
"""

</Literal>
</Sequence>
<CloseBracketToken>]</CloseBracketToken>
Expand Down