Move suppressions to code instead of .gdnsuppress #74467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
the
Community
Member
|
@jasonmalinowski PTAL as change is in IDE layer |
Member
|
Looks fine to me, unless @CyrusNajmabadi wants to comment on it. |
jasonmalinowski
approved these changes
Jul 19, 2024
Member
|
i have absolutely no idea what this is about :D |
3 tasks
jjonescz
approved these changes
Jul 22, 2024
Member
Author
1ES runs tools in official builds (called Guardian) that check the code for various issues, these findings can be baselined with .gdnsuppress so they don't fail the build. But since we sync the code into the VMR repo we need to duplicate all of the entries into a VMR-specific .gdnsuppress file, we can avoid that when the suppression happens in code instead. Looks like this is green so please merge since I don't have permissions :) |
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove duplication of the suppressions in the VMR. I ran an internal build with this change and verified the suppression still works.
/cc @jaredpar