Skip to content

Include SourceLink file in CoreCompile dependency checks #72109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 29, 2024
Merged

Include SourceLink file in CoreCompile dependency checks #72109

merged 2 commits into from
Feb 29, 2024

Conversation

@baronfel
Copy link
Member

@baronfel baronfel commented Feb 14, 2024

A companion to dotnet/msbuild#9743 to ensure that more sourcelink/determinism-related flags correctly cause the compiler to be invoked when they change

@baronfel
Include SourceLink file in CoreCompile dependency checks
90cd6b6 
A companion to dotnet/msbuild#9743 to ensure that more sourcelink/determinism-related flags correctly cause the compiler to be invoked when they change
@baronfel baronfel requested a review from a team as a code owner February 14, 2024 21:48
@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 14, 2024
rainersigwald
rainersigwald suggested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply to VB too please

roslyn/src/Compilers/Core/MSBuildTask/Microsoft.VisualBasic.Core.targets

Lines 6 to 7 in 90cd6b6

<Target Name="CoreCompile"
Inputs="$(MSBuildAllProjects);

@baronfel
Copy link
Member Author

baronfel commented Feb 14, 2024

Thanks @rainersigwald - I've just done so.

@baronfel
Copy link
Member Author

baronfel commented Feb 16, 2024

cc @jaredpar

@jaredpar
Copy link
Member

jaredpar commented Feb 27, 2024

@dotnet/roslyn-compiler PTAL

@jaredpar jaredpar merged commit 7f5ba0f into main Feb 29, 2024
@jaredpar jaredpar deleted the csc-sourcelink-dependency branch February 29, 2024 21:30
@baronfel baronfel mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar approved these changes

@jjonescz jjonescz jjonescz approved these changes

+1 more reviewer

@rainersigwald rainersigwald rainersigwald approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@baronfel @jaredpar @rainersigwald @jjonescz