Add Determinism/SourceLink related Properties to Corecompile dependency checks #9743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one part of dotnet/sdk#16325, identifying two areas where inputs to the CoreCompile Target (via the Csc/Fsc/etc Tasks) aren't tracked consistently.
baronfel
changed the title
baronfel
added a commit
to dotnet/roslyn
that referenced
this pull request
Feb 14, 2024
A companion to dotnet/msbuild#9743 to ensure that more sourcelink/determinism-related flags correctly cause the compiler to be invoked when they change
baronfel
added a commit
to dotnet/fsharp
that referenced
this pull request
Feb 14, 2024
A companion to dotnet/msbuild#9743 to ensure that more sourcelink/determinism-related flags correctly cause the compiler to be invoked when they change
3 tasks
rainersigwald
approved these changes
Feb 14, 2024
ladipro
approved these changes
Feb 16, 2024
jaredpar
pushed a commit
to dotnet/roslyn
that referenced
this pull request
Feb 29, 2024
* Include SourceLink file in CoreCompile dependency checks A companion to dotnet/msbuild#9743 to ensure that more sourcelink/determinism-related flags correctly cause the compiler to be invoked when they change * Also apply SourceLink Input to VB Compiler
psfinaki
pushed a commit
to dotnet/fsharp
that referenced
this pull request
Mar 6, 2024
A companion to dotnet/msbuild#9743 to ensure that more sourcelink/determinism-related flags correctly cause the compiler to be invoked when they change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is one part of dotnet/sdk#16325, identifying two areas where inputs to the CoreCompile Target (via the Csc/Fsc/etc Tasks) aren't tracked consistently.
Fixes part of dotnet/sdk#16325
Changes Made
Adds Deterministic and PathMap properties, neither of which are Paths and so cannot be coerced into an Item for use in the Target Inputs, to the tracking cache property file.
Testing
Notes