Move to DiaSymReader 2.0 #68055
Merged
Move to DiaSymReader 2.0 #68055
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of DiaSymReader had only a `netstandard1.6` target framework. That brought in versions of `System.Private.Uri` that component governance was flagging as an issue: for us and pretty much anyone that took a dependency on our NuPkg. This version has a `netstandard2.0` target so this should alleviate the problem
ghost
added
Area-Infrastructure
untriaged
jaredpar
removed
the
untriaged
Member
Author
|
@dotnet/roslyn-infrastructure PTAL |
Member
Author
|
@Cosifne FYI as this changes on of our dependencies and in theory could impact VS insertion. Seems very unlikely but want to call it out. |
jaredpar
added a commit
to dotnet/razor
that referenced
this pull request
May 2, 2023
The inclusion of System.Private.Uri as a package reference was done to solve component governance issues. This came specificaly from including `nestandard1.6` in our dependency graph via Microsoft.DiaSymReader. There is now a `netstandard2.0` version of that package that we can move to and, _should_, let us remove the System.Private.Uri references. A [similar change](dotnet/roslyn#68055) is going through roslyn now that will eventually let us remove this entirely. In the meantime though it's fine to have an explicit reference here.
333fred
approved these changes
May 2, 2023
jaredpar
added a commit
to dotnet/razor
that referenced
this pull request
May 2, 2023
The inclusion of System.Private.Uri as a package reference was done to solve component governance issues. This came specificaly from including `nestandard1.6` in our dependency graph via Microsoft.DiaSymReader. There is now a `netstandard2.0` version of that package that we can move to and, _should_, let us remove the System.Private.Uri references. A [similar change](dotnet/roslyn#68055) is going through roslyn now that will eventually let us remove this entirely. In the meantime though it's fine to have an explicit reference here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of DiaSymReader had only a
netstandard1.6target framework. That brought in versions ofSystem.Private.Urithat component governance was flagging as an issue: for us and pretty much anyone that took a dependency on our NuPkg. This version has anetstandard2.0target so this should alleviate the problem