Skip to content

Commit f7d2cdf

Browse files
authored
Move to DiaSymReader 2.0 (#8661)
The inclusion of System.Private.Uri as a package reference was done to solve component governance issues. This came specificaly from including `nestandard1.6` in our dependency graph via Microsoft.DiaSymReader. There is now a `netstandard2.0` version of that package that we can move to and, _should_, let us remove the System.Private.Uri references. A [similar change](dotnet/roslyn#68055) is going through roslyn now that will eventually let us remove this entirely. In the meantime though it's fine to have an explicit reference here.
1 parent 3d25dfb commit f7d2cdf

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

eng/Versions.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@
106106
<BenchmarkDotNetPackageVersion>0.13.2.2052</BenchmarkDotNetPackageVersion>
107107
<MicrosoftBuildLocatorPackageVersion>1.2.6</MicrosoftBuildLocatorPackageVersion>
108108
<MicrosoftBuildPackageVersion>16.8.0</MicrosoftBuildPackageVersion>
109+
<MicrosoftDiaSymReaderVersion>2.0.0</MicrosoftDiaSymReaderVersion>
109110
<MicrosoftNETSdkRazorPackageVersion>6.0.0-alpha.1.21072.5</MicrosoftNETSdkRazorPackageVersion>
110111
<!-- Packages from dotnet/roslyn -->
111112
<MicrosoftNetCompilersToolsetVersion>$(MicrosoftNetCompilersToolsetPackageVersion)</MicrosoftNetCompilersToolsetVersion>

src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
<PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" Version="$(BenchmarkDotNetPackageVersion)" />
5555
<PackageReference Include="Microsoft.Extensions.Logging" Version="$(MicrosoftExtensionsPackageVersion)" />
5656
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="$(MicrosoftExtensionsPackageVersion)" />
57-
<PackageReference Include="System.Private.Uri" Version="$(SystemPrivateUriPackageVersion)" ExcludeAssets="true" PrivateAssets="true" />
57+
<PackageReference Include="Microsoft.DiaSymReader" Version="$(MicrosoftDiaSymReaderVersion)" />
5858
</ItemGroup>
5959

6060
</Project>

src/Razor/src/rzls/rzls.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
</PropertyGroup>
4848

4949
<ItemGroup>
50-
<PackageReference Include="System.Private.Uri" Version="$(SystemPrivateUriPackageVersion)" ExcludeAssets="true" PrivateAssets="true" />
50+
<PackageReference Include="Microsoft.DiaSymReader" Version="$(MicrosoftDiaSymReaderVersion)" />
5151
</ItemGroup>
5252

5353
<Target Name="PublishAllRids">

0 commit comments

Comments
 (0)