Skip to content

Perf: Modify StringIndentationTaggerProvider to not tag the whole file on every request. #67631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Perf: Modify StringIndentationTaggerProvider to not tag the whole file on every request. #67631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions src/EditorFeatures/Core.Wpf/StringIndentation/StringIndentationTaggerProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ namespace Microsoft.CodeAnalysis.Editor.Implementation.StringIndentation
/// <summary>
/// This factory is called to create taggers that provide information about how strings are indented.
/// </summary>
[Export(typeof(ITaggerProvider))]
[Export(typeof(IViewTaggerProvider))]
[TagType(typeof(StringIndentationTag))]
[VisualStudio.Utilities.ContentType(ContentTypeNames.CSharpContentType)]
[VisualStudio.Utilities.ContentType(ContentTypeNames.VisualBasicContentType)]
internal sealed partial class StringIndentationTaggerProvider : AsynchronousTaggerProvider<StringIndentationTag>
internal sealed partial class StringIndentationTaggerProvider : AsynchronousViewTaggerProvider<StringIndentationTag>
{
private readonly IEditorFormatMap _editorFormatMap;

Expand Down Expand Up @@ -73,11 +73,29 @@ public StringIndentationTaggerProvider(
protected override SpanTrackingMode SpanTrackingMode => SpanTrackingMode.EdgeInclusive;

protected override ITaggerEventSource CreateEventSource(
ITextView? textView, ITextBuffer subjectBuffer)
ITextView textView, ITextBuffer subjectBuffer)
{
// Note: we don't listen for OnTextChanged. They'll get reported by the ViewSpan changing.
return TaggerEventSources.Compose(
new EditorFormatMapChangedEventSource(_editorFormatMap),
TaggerEventSources.OnTextChanged(subjectBuffer));
TaggerEventSources.OnViewSpanChanged(ThreadingContext, textView),
new EditorFormatMapChangedEventSource(_editorFormatMap));
}

protected override IEnumerable<SnapshotSpan> GetSpansToTag(ITextView? textView, ITextBuffer subjectBuffer)
{
this.ThreadingContext.ThrowIfNotOnUIThread();
Contract.ThrowIfNull(textView);

// Find the visible span some 100 lines +/- what's actually in view. This way
// if the user scrolls up/down, we'll already have the results.
var visibleSpanOpt = textView.GetVisibleLinesSpan(subjectBuffer, extraLines: 100);
if (visibleSpanOpt == null)
{
// Couldn't find anything visible, just fall back to tagging all brace locations
return base.GetSpansToTag(textView, subjectBuffer);
}

return SpecializedCollections.SingletonEnumerable(visibleSpanOpt.Value);
}

protected override async Task ProduceTagsAsync(
Expand Down