Perf: Modify StringIndentationTaggerProvider to not tag the whole file on every request. #67631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e on every request. Instead, switch this to an IViewTaggerProvider and tag the current view +- 100 lines. This changes time spent in CSharpStringIndentationService from about 1700ms to < 50 ms when typing a couple lines of code in a large C# file.
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
Apr 4, 2023
Member
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
approving as long as you smoke tested this on a large file with raw string literals in it (like one of our test case files).
Contributor
Author
Yep, tested by adding several raw string literals to LanguageParser.cs and scrolling through the file and making sure the indentation lines were shown for them. Also verified typing and scrolling both re-queried the system. |
mavasani
added
the
Performance-Scenario-Diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, switch this to an IViewTaggerProvider and tag the current view +- 100 lines. This changes time spent in CSharpStringIndentationService from about 1700ms to < 50 ms when typing a couple lines of code in a large C# file.
*** Previous ***
*** New ***
This reduces samples under GetStringIndentationRegionsAsync from 2.9% to 0.1%.