Add net6.0 TFM to ExternalAccess.Razor #66846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
MissingMethodExceptions in Razor tests after updating Roslyn to a version after #66655. These occur because of mismatch inIsExternalInitattribute (credit for discovering the problem goes to @davidwengier).Details (reference graphs):
Previously, this worked:
Microsoft.AspNetCore.Razor.LanguageServer.Testnet7.0MS.CA.ExternalAccess.Razornetstandard2.0MS.CA.Workspacesnetstandard2.0IsExternalInitattribute embedded ✅MS.CA.Workspacesnetcoreapp3.1IsExternalInitattribute embedded ✅After #66655, it broke:
Microsoft.AspNetCore.Razor.LanguageServer.Testnet7.0MS.CA.ExternalAccess.Razornetstandard2.0MS.CA.Workspacesnetstandard2.0IsExternalInitattribute embedded ❌MS.CA.Workspacesnet6.0 👈 changedIsExternalInitattribute fromSystem.Runtime❌After this PR, it works again:
Microsoft.AspNetCore.Razor.LanguageServer.Testnet7.0MS.CA.ExternalAccess.Razornet6.0 👈 changedMS.CA.Workspacesnet6.0IsExternalInitattribute fromSystem.Runtime✅MS.CA.Workspacesnet6.0IsExternalInitattribute fromSystem.Runtime✅(Alternative would be making
Microsoft.AspNetCore.Razor.LanguageServer.Testtargetnet472. I tried that but got AppDomainUnloaded exceptions in CI.)