Add functional test for C# diagnostics #8285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And write tests to test the test changes!
davidwengier
changed the title
DustinCampbell
approved these changes
Feb 16, 2023
333fred
approved these changes
Feb 16, 2023
Member
333fred
left a comment
333fred
left a comment
There was a problem hiding this comment.
Version change is fine with me. I didn't look at the code changes :).
Member
Author
|
Going to update this to an even newer Roslyn version to get dotnet/roslyn#66846 to fix the test failures. FYI @jjonescz in case you were needing that in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to dotnet/roslyn#66748 being available, needed to write proper tests for #8204 (and have a sane dev experience)
Figured I'd put this up separately so there is less in flight on my machine. Not the worlds most earth shattering tests :)