17.4: Convert symbol-search crash to NFW#65280
Merged
arunchndr merged 1 commit intodotnet:release/dev17.4from Nov 16, 2022
Merged
17.4: Convert symbol-search crash to NFW#65280arunchndr merged 1 commit intodotnet:release/dev17.4from
arunchndr merged 1 commit intodotnet:release/dev17.4from
Conversation
ghost
added
the
arunchndr
approved these changes
Nov 8, 2022
dibarbet
approved these changes
Nov 8, 2022
| await LogInfoAsync("Converting data to XElement completed", cancellationToken).ConfigureAwait(false); | ||
| return (element, delay: default); | ||
| } | ||
| catch (Exception e) when (_service._reportAndSwallowExceptionUnlessCanceled(e, cancellationToken)) |
Contributor
Author
There was a problem hiding this comment.
Answered in other PR. this allows the tests to actually validate tehse codepaths without actually invoking FatalError (which kills tests).
CyrusNajmabadi
changed the title
ryzngard
approved these changes
Nov 8, 2022
Contributor
|
This is now targeting 17.4.2 servicing. So let's keep this on deck until the 17.4.1 clears out and merge after. |
Contributor
Author
|
@arkalyanms Sounds good. LMK when this can go in. |
Contributor
Author
|
@arkalyanms are we still waiting on this? |
Contributor
|
Yes the 17.4.2 branch has not opened up yet (on Nov 21st). But this has soft approval, so should be fine to merge here and insert into VS when time comes. cc: @jasonmalinowski |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #65279 to 17.4