Convert symbol-search crash to NFW#65279
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Nov 8, 2022
Merged
Conversation
ghost
added
the
arunchndr
approved these changes
Nov 8, 2022
jasonmalinowski
approved these changes
Nov 8, 2022
| } | ||
|
|
||
| bool ReportAndDoNotCatch(Exception exception) | ||
| catch (Exception e) when (_service._reportAndSwallowExceptionUnlessCanceled(e, cancellationToken)) |
Member
There was a problem hiding this comment.
What's with the _service. thing here having a function we're calling as opposed to just using the existing static methods?
Member
There was a problem hiding this comment.
(this is not blocking for taking this in to 17.4 of course)
Contributor
Author
There was a problem hiding this comment.
this was for testing purposes. we actually validate these codepaths in tests, and it allows the test system to inject a helper that fails-fast as opposed to gracefully falling over (like the main code does).
dibarbet
approved these changes
Nov 8, 2022
| } | ||
|
|
||
| bool ReportAndDoNotCatch(Exception exception) | ||
| catch (Exception e) when (_service._reportAndSwallowExceptionUnlessCanceled(e, cancellationToken)) |
CyrusNajmabadi
commented
Nov 8, 2022
src/Features/Core/Portable/SymbolSearch/Windows/SymbolSearchUpdateEngine.Update.cs
Outdated
Show resolved
Hide resolved
…dateEngine.Update.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#1584512