Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Implement equality semantics for async tagger tags." #64867

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

genlu
Copy link
Member

@genlu genlu commented Oct 20, 2022

Reverts #64802 to fix errors in insertion, which breaks TypeScript tagger

  1. Implement equality semantics for async tagger tags. #64802 (comment)
  2. https://github.com/dotnet/roslyn/pull/64802/files#r1000998300

FYI @CyrusNajmabadi a dual insertion with TS is required to reinstate the change

@genlu genlu requested review from a team as code owners October 20, 2022 18:30
@genlu genlu requested a review from a team October 20, 2022 18:38
@CyrusNajmabadi
Copy link
Member

what is the error in insertion?

@CyrusNajmabadi
Copy link
Member

if there is a third party that is extending this type, we can solve this by making the member non-abstract, and giving it a default impl of object.Equals(tag1, tag2);

@CyrusNajmabadi
Copy link
Member

I can make such a change fyi.

@CyrusNajmabadi
Copy link
Member

Non-breaking fix here: #64869

@RikkiGibson
Copy link
Contributor

In general, it's encouraged to link the associated insertion when opening a revert.

@genlu
Copy link
Member Author

genlu commented Oct 20, 2022

@RikkiGibson Thanks for the reminder, link to insertion added

@Cosifne
Copy link
Member

Cosifne commented Oct 20, 2022

BTW the original change also breaks the Integration test.
See my PR here for the fix #64852

@JoeRobich JoeRobich merged commit a989759 into main Oct 20, 2022
@ghost ghost added this to the Next milestone Oct 20, 2022
@genlu genlu deleted the revert-64802-tagEquality branch October 21, 2022 17:18
CyrusNajmabadi added a commit to CyrusNajmabadi/roslyn that referenced this pull request Oct 21, 2022
…quality"

This reverts commit a989759, reversing
changes made to 4f15fa1.
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants