-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Implement equality semantics for async tagger tags." #64867
Conversation
what is the error in insertion? |
if there is a third party that is extending this type, we can solve this by making the member non-abstract, and giving it a default impl of |
I can make such a change fyi. |
Non-breaking fix here: #64869 |
In general, it's encouraged to link the associated insertion when opening a revert. |
@RikkiGibson Thanks for the reminder, link to insertion added |
BTW the original change also breaks the Integration test. |
Reverts #64802 to fix errors in insertion, which breaks TypeScript tagger
FYI @CyrusNajmabadi a dual insertion with TS is required to reinstate the change