Verify the error type and span only for error tag

[Cosifne]

Try to fix the test failure
https://dev.azure.com/dnceng-public/public/_build/results?buildId=57273&view=ms.vss-test-web.build-test-results-tab&runId=1175948&resultId=100668&paneView=debug

We introduced a new type RoslynErrorTag
https://github.com/dotnet/roslyn/blob/main/src/EditorFeatures/Core/Diagnostics/AbstractDiagnosticsAdornmentTaggerProvider.RoslynErrorTag.cs
so it breaks the integrationt test.

I feel the logic to verify using the fully qualified name is quite fragile, so use the error type + span to do the verification work.

Need to wait for a run to see if test passed in CI

[Cosifne]

The original PR introduce the error has been reverted. So this would not be needed right now

[jasonmalinowski]

@Cosifne Should we close this then?

[Cosifne]

@Cosifne Should we close this then?

If possible can we still check this in? I still see some minor race when verify error tag

I feel my change here would give us more about the error message, and generally I feel it is more stable than only asserting string
(e.g. I think if this race happens again, we can know the syntax error Id with the message, so it would be easier to locate the problem)