Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Consider types with ref fields as managed (#63209)" #63367

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Revert "Consider types with ref fields as managed (#63209)" #63367

merged 1 commit into from
Aug 12, 2022

Conversation

cston
Copy link
Member

@cston cston commented Aug 12, 2022

This reverts commit e3985ed.

@cston cston requested a review from a team as a code owner August 12, 2022 20:39
333fred
333fred approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to rationalize this, as it's a particularly unsafe scenario.

@cston cston mentioned this pull request Aug 12, 2022
Closed
@hoyosjs
Copy link
Member

hoyosjs commented Aug 12, 2022

Is this ready to merge? We'll need this in runtime for the RC1 snap.

@cston cston merged commit 76bd0d9 into dotnet:main Aug 12, 2022
@ghost ghost added this to the Next milestone Aug 12, 2022
@cston cston modified the milestones: Next, 17.4 Aug 12, 2022
@cston cston mentioned this pull request Aug 12, 2022
Closed
@allisonchou allisonchou mentioned this pull request Aug 16, 2022
Closed
jcouv added a commit to jcouv/roslyn that referenced this pull request Sep 15, 2022
@jcouv
Revert "Revert "Consider types with ref fields as managed (dotnet#63209…
06ddab0 
…)" (dotnet#63367)"

This reverts commit 76bd0d9.
jcouv added a commit to jcouv/roslyn that referenced this pull request Sep 16, 2022
@jcouv
Revert "Revert "Consider types with ref fields as managed (dotnet#63209…
46e01bc 
…)" (dotnet#63367)"

This reverts commit 76bd0d9.
jcouv added a commit to jcouv/roslyn that referenced this pull request Sep 16, 2022
@jcouv
Revert "Revert "Consider types with ref fields as managed (dotnet#63209…
e40ecf2 
…)" (dotnet#63367)"

This reverts commit 76bd0d9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
17.4
Development

Successfully merging this pull request may close these issues.
4 participants
@cston @hoyosjs @jaredpar @333fred