-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source-build fails to build w/CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type #73850
Comments
Tagging subscribers to this area: @hoyosjs Issue DetailsThe latest dependency flow into installer's broke source-build w/the following errors:
CI Build Failure (internal Microsoft link) Source-build does build with the latest compiler version and toolset which is likely a contributing factor here.
|
This is currently blocking RC1. |
Oof. looks like we're using a roslyn that's not new enough for the bootstrap? cc: @AaronRobinsonMSFT |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThe latest dependency flow into installer's broke source-build w/the following errors:
CI Build Failure (internal Microsoft link) Source-build does build with the latest compiler version and toolset which is likely a contributing factor here.
|
This issue was introduced by dotnet/roslyn#63209 . I do not see the fixes for it in #73466 yet. The problem is that C# disallows taking an address of ref struct that contains ref fields. It is artificial C# limitation that does not exist in IL. It will be pain to workaround it without taking a perf hit. Any chance we can relax the C# rules and allow taking an address of ref structs that contain object references? |
For now, we're reverting dotnet/roslyn#63209 to unblock moving to the latest compiler. See dotnet/roslyn#63367. |
We assembled a source-build run with patches that revert dotnet/roslyn#63209 and pull in the #73466 changes with the very last sdk/roslyn and a new break appeared. You can see the source-build configuration here - dotnet/installer#14319
I can log a new issue for this if you would like. |
Sorry for missing the nativeaot case. I've created #73883 which compiles with |
dotnet/roslyn#63367 and #73883 have been merged. |
@jeffschwMSFT, @MichaelSimons, I've closed this issue since the PRs for the two issues have been merged. Please re-open if there is still something blocking here. |
The latest dependency flow into installer's broke source-build w/the following errors:
CI Build Failure (internal Microsoft link)
Source-build does build with the latest compiler version and toolset which is likely a contributing factor here.
The text was updated successfully, but these errors were encountered: