Source-build fails to build w/CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type

[MichaelSimons]

The latest dependency flow into installer's broke source-build w/the following errors:

  /tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs(319,50): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBase.cs(249,23): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('ByReference') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBase.cs(254,23): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('ByReference') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs(149,54): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(146,54): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs(302,54): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/DynamicMethod.cs(507,54): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]

CI Build Failure (internal Microsoft link)

Source-build does build with the latest compiler version and toolset which is likely a contributing factor here.

[ghost]

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The latest dependency flow into installer's broke source-build w/the following errors:

  /tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs(319,50): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBase.cs(249,23): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('ByReference') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBase.cs(254,23): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('ByReference') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs(149,54): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(146,54): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs(302,54): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/DynamicMethod.cs(507,54): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]

CI Build Failure (internal Microsoft link)

Source-build does build with the latest compiler version and toolset which is likely a contributing factor here.

Author:	MichaelSimons
Assignees:	-
Labels:	area-Infrastructure-coreclr
Milestone:	-

[MichaelSimons]

This is currently blocking RC1.

[hoyosjs]

Oof. looks like we're using a roslyn that's not new enough for the bootstrap? cc: @AaronRobinsonMSFT

[ghost]

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The latest dependency flow into installer's broke source-build w/the following errors:

  /tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs(319,50): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBase.cs(249,23): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('ByReference') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBase.cs(254,23): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('ByReference') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs(149,54): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(146,54): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs(302,54): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/DynamicMethod.cs(507,54): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('MethodBase.StackAllocatedByRefs') [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]

CI Build Failure (internal Microsoft link)

Source-build does build with the latest compiler version and toolset which is likely a contributing factor here.

Author:	MichaelSimons
Assignees:	-
Labels:	blocking-release, area-Infrastructure
Milestone:	7.0.0

[AaronRobinsonMSFT]

Thanks @hoyosjs. The fix for this is in-flight #73466.

[jkotas]

This issue was introduced by dotnet/roslyn#63209 . I do not see the fixes for it in #73466 yet.

The problem is that C# disallows taking an address of ref struct that contains ref fields. It is artificial C# limitation that does not exist in IL. It will be pain to workaround it without taking a perf hit. Any chance we can relax the C# rules and allow taking an address of ref structs that contain object references?

[AaronRobinsonMSFT]

I do not see the fixes for it in #73466 yet.

I know I've discussed this issue with @cston offline. I thought this issue was included in that PR. Let me follow-up offline.

[cston]

For now, we're reverting dotnet/roslyn#63209 to unblock moving to the latest compiler. See dotnet/roslyn#63367.

[MichaelSimons]

We assembled a source-build run with patches that revert dotnet/roslyn#63209 and pull in the #73466 changes with the very last sdk/roslyn and a new break appeared. You can see the source-build configuration here - dotnet/installer#14319

    /tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs(548,28): error CS8167: Cannot return by reference a member of parameter 'exInfo' because it is not a ref or out parameter [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs(548,13): error CS8350: This combination of arguments to 'EH.DispatchEx(ref StackFrameIterator, ref EH.ExInfo, uint)' is disallowed because it may expose variables referenced by parameter 'frameIter' outside of their declaration scope [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs(570,28): error CS8167: Cannot return by reference a member of parameter 'exInfo' because it is not a ref or out parameter [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs(570,13): error CS8350: This combination of arguments to 'EH.DispatchEx(ref StackFrameIterator, ref EH.ExInfo, uint)' is disallowed because it may expose variables referenced by parameter 'frameIter' outside of their declaration scope [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs(587,28): error CS8167: Cannot return by reference a member of parameter 'exInfo' because it is not a ref or out parameter [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj]
    /tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs(587,13): error CS8350: This combination of arguments to 'EH.DispatchEx(ref StackFrameIterator, ref EH.ExInfo, uint)' is disallowed because it may expose variables referenced by parameter 'frameIter' outside of their declaration scope [/tarball/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj]

I can log a new issue for this if you would like.

[cston]

Sorry for missing the nativeaot case.

I've created #73883 which compiles with build -rc Release without errors - with the exception of tools/dotnet-pgo which fails to compile with the latest compiler because it references .NET preview 5 SDK.

[cston]

dotnet/roslyn#63367 and #73883 have been merged.

[cston]

@jeffschwMSFT, @MichaelSimons, I've closed this issue since the PRs for the two issues have been merged. Please re-open if there is still something blocking here.