Bulk suppression performance fixes #6093
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I scanned for other occurences of "?.Kind()", but found none.
This fixes an issue in VB where we would add the desktop mscorlib to the project.
…perty for the instance of the form.
The NuGet build script should explicitly take a directory to which we write the built package.
Old vbc compiler used to allow property assignments (even though technically no assignemnets should be allowed) This fixes dotnet#4524 Caveat: old compiler also allowed compound property assignments like += and generated bad code for them We are not going to allow that unless some major use patters are discovered. It is generally not possible to implement that correctly using ExpressionTrees v1.0 node set.
When renaming a VB form, cascade to the synthesized compiler "My" property for the instance of the form. Fixes dotnet#4517
* stabilization: Adding back in a character removed in an earlier fix.
Add outdir parameter to BuildNuGets.csx
1. Fix a race condition in IDELatestDiagnosticGetter, when used is concurrent mode it might return incomplete set of diagnostics. This affects both FixAll behavior as bulk suppression from error list - we might drop diagnostics from the batch fix. 2. Thread in the cancellation token into bulk suppression batch fix computation - otherwise IDE becomes unresponsive on cancelling computation of suppressions fix.
Conflicts: Compilers.sln Roslyn.sln cibuild.cmd
…lace the result logs in it.
And update project.lock.json
…w ExportProvider rather than underlying data might have been shared between multiple export providers.
provide HelpKeyword information for offline help
Switch our CoreCLR projects to be ".NETPortable,v5.0"
…tests Re-unskip code model tests
Introduce xunit based performance testing
Changed "tests" -> "test assemblies" to better reflect what the test runner is doing
AppConfigBasicFail fails at home because I have an "I" drive that is plugged in. Change it to use an existent drive, so the drive is connected, but the path just can't be found.
Do async locking correctly
Update toolset compiler to 1.1.0-rc1-20151014-05
…ession feature: 1) "Suppress active issues" command from solution explorer was doing couple of builds - one command line build to compute the FxCop diagnostics and another intellisense build to fetch Roslyn diagnostics. This change removes the second build and instead uses the diagnostics emitted from the build for suppression. 2) Bulk suppressing multiple diagnostics from error list/suppress active issues command was spending more than 50% of time in formatting the generated global suppressions file. This delay grows significantly larger with 1000+ issues being suppressed. This fix changes us to not format the entire suppressions file at once, but instead format each attribute separately and avoid formating the batched file. This signficantly brings down the formatting time. Fixes dotnet#6066
made WorkCoordinator test to use its own MEF containers that are not shared with others
Change AppConfigBasicFail to use a drive that is connected
Contributor
Author
|
Opened #6096 against stabilization, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the performance issues for baselining/bulk suppression feature:
Fixes #6066