provide HelpKeyword information for offline help #5907
Conversation
|
@mavasani can you take a look? this gives information for error list to show offline help viewer in offline mode. |
There was a problem hiding this comment.
@heejaechang Looking at the PR I realized I only added handler for SuppressionStateColumnDefinition.ColumnName in live source but not for build source, I will make that fix tomorrow.
There was a problem hiding this comment.
There is a lot of redundancy in this method. Why not have a "GetValue" method that just returns things like data.id. Then have htis method be:
bool TryGetValue(...)
{
var value = GetValue(...);
return value != null;
}It should cut down the size of this method (and the repeated code) by nearly half.
There was a problem hiding this comment.
@CyrusNajmabadi some of them could, but I dont think it is that bad to require cleaning up.
|
👍 |
|
I think you also need to add this fix to FxCop? |
|
@mavasani good point. I will make the change in FxCop as well. |
|
@dotnet-bot retest linux please |
1 similar comment
|
@dotnet-bot retest linux please |
|
@dotnet-bot retest this please |
1 similar comment
|
@dotnet-bot retest this please |
|
@dotnet-bot retest this please |
1 similar comment
|
@dotnet-bot retest this please |
|
Jenkins seems in weird state. each tests (actually not "test" but test runner) are failing due to arbitrary reasons each time I re-run. and each failure looks like nothing to do with my change. |
|
test prtest/lin/dbg/unit32 please |
|
test prtest/win/dbg/eta please |
|
test win eta please |
|
@dotnet-bot retest win eta please |
|
test win eta please |
provide HelpKeyword information for offline help
Merge IEnumerable analyzer to main
5 participants
No description provided.