Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CA1514: Remove redundant length argument #6814

Merged
merged 7 commits into from
Sep 22, 2023
Merged

Commits on Jul 28, 2023

  1. Add CA1514: Remove redundant length argument

    This analyzer detects uses of Substring/Slice(start, length) that slice
    to the end of the buffer. In these cases, the length check is redundant,
    can be omitted, and the call can be replaced with
    Substring/Slice(start). The analyzer also detects if the evaluation of
    the instance or arguments can lead to side effects and does not flag
    these cases.
    mpidash committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9ef0cb9 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Fix copy-paste error

    mpidash committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    9164b28 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Apply suggestions from code review

    Co-authored-by: Buyaa Namnan <[email protected]>
    mpidash and buyaa-n authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    28423c6 View commit details
    Browse the repository at this point in the history
  2. Rename LengthCheck to LengthCalculation

    Also use the new code fix title for the fixer and rerun msbuild pack.
    mpidash committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    c43dc18 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4a0c290 View commit details
    Browse the repository at this point in the history
  4. Run msbuild pack

    mpidash committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    5661ffc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fa03bad View commit details
    Browse the repository at this point in the history