Add CA1514: Remove redundant length argument

[mpidash]

Fixes dotnet/runtime#68946.

This analyzer detects uses of Substring/Slice(start, length) that slice to the end of the buffer.
In these cases, the length check is redundant, can be omitted, and the call can be replaced with Substring/Slice(start).
The analyzer also detects if the evaluation of the instance or arguments can lead to side effects and does not flag these cases.

I have found no warning when running the analyzer against dotnet/runtime and dotnet/roslyn-analyzers, 1 warning in dotnet/roslyn and 8 warnings in dotnet/aspnetcore:

1. ContainedLanguageCodeSupport.cs(427,38): info CA1514: 'string.Substring(int, int)' uses a length check that can be avoided
2. EmbeddedFileProvider.cs(95,23): info CA1514: 'string.Substring(int, int)' uses a length check that can be avoided
3. RoutePatternParserTests.cs(112,17): info CA1514: 'string.Substring(int, int)' uses a length check that can be avoided
4. MultipartReader.cs(124,25): info CA1514: 'string.Substring(int, int)' uses a length check that can be avoided
5. AsciiDecoding.cs(108,78): info CA1514: 'System.Span.Slice(int, int)' uses a length check that can be avoided
6. AsciiDecoding.cs(109,75): info CA1514: 'string.Substring(int, int)' uses a length check that can be avoided
7. Program.cs(465,69): info CA1514: 'string.Substring(int, int)' uses a length check that can be avoided
8. Utf8BufferTextWriter.cs(199,23): info CA1514: 'System.Memory.Slice(int, int)' uses a length check that can be avoided
9. Utf8BufferTextWriterTests.cs(381,20): info CA1514: 'System.Memory.Slice(int, int)' uses a length check that can be avoided

Not sure about the resource strings, would appreciate any suggestions.

[codecov]

Codecov Report

Merging #6814 (9164b28) into main (4aefee9) will decrease coverage by 0.03%.
The diff coverage is 97.25%.

❗ Current head 9164b28 differs from pull request most recent head fa03bad. Consider uploading reports for the commit fa03bad to get more accurate results

@@            Coverage Diff             @@
##             main    #6814      +/-   ##
==========================================
- Coverage   96.42%   96.39%   -0.03%     
==========================================
  Files        1398     1406       +8     
  Lines      333552   332375    -1177     
  Branches    11038    10923     -115     
==========================================
- Hits       321624   320408    -1216     
- Misses       9165     9212      +47     
+ Partials     2763     2755       -8     

[buyaa-n]

Thanks you @mpidash, left a few comments, overall LGTM

[buyaa-n]

I have found no warning when running the analyzer against dotnet/runtime and dotnet/roslyn-analyzers, 1 warning in dotnet/roslyn and 8 warnings in dotnet/aspnetcore:

Thanks for broad testing, all looks valid and worth fixing.

[mpidash]

Thanks for the review @buyaa-n, I've addressed your review, merged main, and rerun msbuild pack, PTAL :)

[mpidash]

Seems like msbuild pack does not add a trailing newline to AnalyzerReleases.Unshipped.md, I've added it manually.