Remove Async Keyword For Generate Async Method Code Action #9030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonchou
approved these changes
Jul 26, 2023
ryzngard
approved these changes
Jul 26, 2023
davidwengier
approved these changes
Jul 26, 2023
ghost
added this to the
lonitra
added a commit
to lonitra/razor
that referenced
this pull request
Jul 27, 2023
* Remove async keyword from generate async method * Ensure namespace for code behind tests is correct
lonitra
added a commit
that referenced
this pull request
Jul 27, 2023
333fred
added a commit
to 333fred/razor
that referenced
this pull request
Aug 23, 2023
* upstream/main: (188 commits) Rename CSHTML file reference. (dotnet#8969) Remove Omnisharp logic from main branch (dotnet#9027) Update dependencies from https://github.com/dotnet/arcade build 20230726.1 Fixes CVE-2023-33127 and CVE-2023-33170 (dotnet#9032) Remove Async Keyword For Generate Async Method Code Action (dotnet#9030) Remove dispatcher from DocumentVersionCache (dotnet#9026) Restore perf work. (dotnet#8995) Implement priority trigger support Change implementations and references Rename ProjectSnapshotChangeTrigger and convert to interface Updates after merge Fix nullability Use pattern matching Convert to record struct Move CloseTextTagOnAutoInsertProvider to FindToken (dotnet#9025) Move GenerateMethodCodeActionProvider to FindToken (dotnet#8988) Add comment describing when ProjectRazorJson.Version should be incremented Some more violations, after the merge Remove TryResolveDocument method [Infra] 17.8 P1 snap PRs (dotnet#9021) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
asynckeyword from method generation when executing 'Generate Async Method' code action to align with C# behavior and update tests