Rename CSHTML file reference. #8969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryamariyan
approved these changes
Jul 18, 2023
luckmandev81
approved these changes
Jul 18, 2023
ryzngard
approved these changes
Jul 18, 2023
Member
|
Was this PoliCheck? You know you can just close those as By Design or Won't Fix if the use is not in a sensetive context? 😛 |
allisonchou
approved these changes
Jul 19, 2023
Member
Author
According to the docs, that should be sufficient. |
phil-allen-msft
force-pushed
the
dev/phil-allen-msft/renameCshtmlFileReference
branch
from
1ef92e4 to
34f6473
Compare
phil-allen-msft
deleted the
dev/phil-allen-msft/renameCshtmlFileReference
branch
ghost
added this to the
333fred
added a commit
to 333fred/razor
that referenced
this pull request
Aug 23, 2023
* upstream/main: (188 commits) Rename CSHTML file reference. (dotnet#8969) Remove Omnisharp logic from main branch (dotnet#9027) Update dependencies from https://github.com/dotnet/arcade build 20230726.1 Fixes CVE-2023-33127 and CVE-2023-33170 (dotnet#9032) Remove Async Keyword For Generate Async Method Code Action (dotnet#9030) Remove dispatcher from DocumentVersionCache (dotnet#9026) Restore perf work. (dotnet#8995) Implement priority trigger support Change implementations and references Rename ProjectSnapshotChangeTrigger and convert to interface Updates after merge Fix nullability Use pattern matching Convert to record struct Move CloseTextTagOnAutoInsertProvider to FindToken (dotnet#9025) Move GenerateMethodCodeActionProvider to FindToken (dotnet#8988) Add comment describing when ProjectRazorJson.Version should be incremented Some more violations, after the merge Remove TryResolveDocument method [Infra] 17.8 P1 snap PRs (dotnet#9021) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Rename the reference. Since the referenced file isn't actually anywhere on disk and this is being used to measure the performance of the project razor json handling code in general, it doesn't need to match an actual file.
Fixes:
https://dev.azure.com/devdiv/DevDiv/_queries/edit/1826430