Add property access codegen for component attributes that otherwise don't need codegen #8512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue with `@bind-Value:get` not working correctly, I just missed a couple of constructors in my last PR for some reason.
…eneration These don't have any job at runtime, or even most of design time, but help with generating property access code that represents specifying the attributes.
Only the intermediate tree has changed, which is what we want
Tree, mappings and code gen have all changed.
jjonescz
approved these changes
Mar 27, 2023
Member
Author
|
@dotnet/razor-compiler for second review, and to see how you feel about a slightly larger tree :) |
333fred
reviewed
Apr 11, 2023
...Microsoft.AspNetCore.Razor.Language/test/IntegrationTests/ComponentCodeGenerationTestBase.cs
Show resolved
Hide resolved
davidwengier
force-pushed
the
FixComponentPropertiesWithSuffixes
branch
from
553b23a to
72281e7
Compare
Member
Author
|
Ping @dotnet/razor-compiler for a 2nd review |
Member
Author
|
Ping @dotnet/razor-compiler PTAL |
333fred
approved these changes
May 2, 2023
This was referenced May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8498
When I did #7974 I failed to allow for attributes that were not added to the intermediate tree during lowering, which resulted in missing source mappings and code gen, and hence lack of IDE functionality.
This fixes that by generating intermediate nodes for these attributes, but also flags them as being solely for design time help so runtime codegen is not changed. The intermediate tree does get a few more nodes, and I could make the
Acceptmethod a no-op for these nodes, so tree visitors are unaffected, but that seemed a bit smelly, and ultimately there weren't too many new spots where these new nodes had to be skipped. Let me know if you disagree.Again, commit-at-a-time makes the most sense, just to see logic changes versus test baseline changes.