Skip to content

Update invalid langver error message #12611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidwengier merged 2 commits into from
Dec 18, 2025
Merged

Update invalid langver error message #12611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
423eeb7
Update invalid langver error message
jjonescz Dec 17, 2025
c4fbc5a
Add a parameter for max lang version
jjonescz Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...alysis.Razor.Compiler/src/SourceGenerators/Diagnostics/RazorSourceGeneratorResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
<value>Invalid RazorLangVersion</value>
</data>
<data name="InvalidRazorLangMessage" xml:space="preserve">
<value>Invalid value '{0}'' for RazorLangVersion. Valid values include 'Latest' or a valid version in range 1.0 to 8.0.</value>
<value>Invalid value '{0}' for RazorLangVersion. Valid values include 'Latest', 'Preview', or a valid version in range 1.0 to {1}.</value>
</data>
<data name="RecomputingTagHelpersTitle" xml:space="preserve">
<value>Recomputing tag helpers</value>
Expand Down
3 changes: 2 additions & 1 deletion ...t.CodeAnalysis.Razor.Compiler/src/SourceGenerators/RazorSourceGenerator.RazorProviders.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ public partial class RazorSourceGenerator
diagnostic = Diagnostic.Create(
RazorDiagnostics.InvalidRazorLangVersionDescriptor,
Location.None,
razorLanguageVersionString);
razorLanguageVersionString,
RazorLanguageVersion.Preview.ToString());
razorLanguageVersion = RazorLanguageVersion.Latest;
}

Expand Down
8 changes: 4 additions & 4 deletions ...Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/RazorSourceGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Razor.Language.Syntax;
using Microsoft.AspNetCore.Razor.Language;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.Test.Utilities;
Expand Down Expand Up @@ -3101,8 +3101,8 @@ public async Task RazorLangVersion_Incorrect([CombinatorialValues("incorrect", "
var result = RunGenerator(compilation!, ref driver);

result.Diagnostics.Verify(
// error RZ3600: Invalid value '{0}'' for RazorLangVersion. Valid values include 'Latest' or a valid version in range 1.0 to 8.0.
Diagnostic("RZ3600").WithArguments(langVersion).WithLocation(1, 1));
// error RZ3600: Invalid value '{0}' for RazorLangVersion. Valid values include 'Latest', 'Preview', or a valid version in range 1.0 to {1}.
Diagnostic("RZ3600").WithArguments(langVersion, RazorLanguageVersion.Preview.ToString()).WithLocation(1, 1));
Assert.Single(result.GeneratedSources);
}

Expand Down Expand Up @@ -3272,7 +3272,7 @@ public async Task IncrementalCompilation_OnlyCompilationRuns_When_MetadataRefere
Assert.Equal(2, result.GeneratedSources.Length);
Assert.Empty(eventListener.Events);

var reference = (PortableExecutableReference) project.MetadataReferences[^1];
var reference = (PortableExecutableReference)project.MetadataReferences[^1];

project = project.RemoveMetadataReference(reference)
.AddMetadataReference(MetadataReference.CreateFromFile(reference.FilePath!));
Expand Down