Update invalid langver error message#12611
Conversation
| </data> | ||
| <data name="InvalidRazorLangMessage" xml:space="preserve"> | ||
| <value>Invalid value '{0}'' for RazorLangVersion. Valid values include 'Latest' or a valid version in range 1.0 to 8.0.</value> | ||
| <value>Invalid value '{0}' for RazorLangVersion. Valid values include 'Latest' or a valid version in range 1.0 to 11.0.</value> |
There was a problem hiding this comment.
TIL. And also I'm definitely going to forget to update this again next year. Can we make the 11.0 an argument, and pass in RazorLangVersion.Preview when creating the diagnostic?
Also should probably add "'Preview'" to the valid values mentioned
There was a problem hiding this comment.
I added a test to catch this next year, but making this an argument sounds even better, thanks.
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
In case adding another argument is difficult, or impossible, this is clearly still an improvement :)
|
@dotnet/razor-tooling do I need another review here? If not, feel free to merge this, thanks |
|
Nope, we don't have enough team members to require two reviewers. It's the Wild West! :) |
|
That was partly my question, but partly also if I need another review for the additional commit I pushed since your sign off. Thanks! |
2 participants
No description provided.