Add source mapping for @rendermode#12592
Closed
davidwengier wants to merge 10 commits intodotnet:dev/dawengie/RenderModeWithTypeParamfrom
Closed
Add source mapping for @rendermode#12592davidwengier wants to merge 10 commits intodotnet:dev/dawengie/RenderModeWithTypeParamfrom
@rendermode#12592davidwengier wants to merge 10 commits intodotnet:dev/dawengie/RenderModeWithTypeParamfrom
Conversation
Got sick of adding lots and lots of parameters. Going to clean these up in future
davidwengier
commented
Dec 12, 2025
| : IntermediateNodeFactory.CSharpToken( | ||
| content: directiveToken.Content, | ||
| // To avoid breaking hot reload, we don't map the content back to the source unless we're on Razor 10 or higher | ||
| source: codeDocument.ParserOptions.LanguageVersion >= RazorLanguageVersion.Version_10_0 |
Member
Author
There was a problem hiding this comment.
Rather than gating this on a language version, we could just add a source mapping and not a line directive for these, which would solve the problem in the IDE, but wouldn't solve CLI build diagnostics (which are presumably broken), and would mean adding a new property to IntermediateNode so wanted to see if anyone cared first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #12590 because I needed the new language version. Will merge that first, then rebase this, obv.
Fixes #10668