Allow @rendermode and @typeparam to coexist in basic scenarios#12590
Closed
davidwengier wants to merge 4 commits intodotnet:mainfrom
Closed
Allow @rendermode and @typeparam to coexist in basic scenarios#12590davidwengier wants to merge 4 commits intodotnet:mainfrom
@rendermode and @typeparam to coexist in basic scenarios#12590davidwengier wants to merge 4 commits intodotnet:mainfrom
Conversation
davidwengier
commented
Dec 12, 2025
| ["7.0"] = Version_7_0, | ||
| ["8.0"] = Version_8_0, | ||
| ["9.0"] = Version_9_0, | ||
| ["10.0"] = Version_10_0, |
Member
Author
There was a problem hiding this comment.
This feature needs to be tied to .NET 11 in order to not break CI builds, we just have to decide what Razor lang version that is. .NET 10 shipped with RazorLangVersion 9, sadly, and it's not clear to me if its too late to change that so everything lines up nicely:
https://github.com/dotnet/sdk/blob/main/src/RazorSdk/Targets/Sdk.Razor.CurrentVersion.targets#L57
Member
Author
|
Superseded by #12591 |
This was referenced Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9683
This doesn't fix the issue in all scenarios, due to limitations of C# (not allowing open generics in attribute names, for example), but the specific cases where this doesn't work, the workaround of defining your own attribute and using
[attribute: ...]also doesn't work, so I think this is a net positive and unblocks the common case for users.