Skip to content

TagHelperCollection Part 4: Rewrite Tag Helper Discovery(!) #12507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DustinCampbell merged 5 commits into from
Nov 24, 2025
Merged

TagHelperCollection Part 4: Rewrite Tag Helper Discovery(!) #12507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c55d7c
Introduce TagHelperDiscoveryService with assembly-level cache
DustinCampbell Nov 13, 2025
8751f22
Break dependency between bind and component tag helper providers
DustinCampbell Nov 14, 2025
e94a840
Implement producers with factory pattern for all tag helper providers
DustinCampbell Nov 15, 2025
17b5e22
Make TagHelperDiscoveryService walk assemblies rather than the providers
DustinCampbell Nov 17, 2025
f4a353a
Remove #nullable disable from a few files
DustinCampbell Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions ...mponentTagHelperDescriptorProviderTest.cs → ...est/ViewComponentTagHelperProducerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X;

// This is just a basic integration test. There are detailed tests for the VCTH visitor and descriptor factory.
public class ViewComponentTagHelperDescriptorProviderTest
public class ViewComponentTagHelperProducerTest
{
[Fact]
public void DescriptorProvider_FindsVCTH()
Expand All @@ -24,12 +24,13 @@ public class StringParameterViewComponent

var compilation = MvcShim.BaseCompilation.AddSyntaxTrees(CSharpSyntaxTree.ParseText(code));

var context = new TagHelperDescriptorProviderContext(compilation);

var provider = new ViewComponentTagHelperDescriptorProvider()
var projectEngine = RazorProjectEngine.CreateEmpty(static b =>
{
Engine = RazorProjectEngine.CreateEmpty().Engine,
};
b.Features.Add(new ViewComponentTagHelperProducer.Factory());
b.Features.Add(new TagHelperDiscoveryService());
});

Assert.True(projectEngine.Engine.TryGetFeature(out ITagHelperDiscoveryService? service));

var expectedDescriptor = TagHelperDescriptorBuilder.CreateViewComponent("__Generated__StringParameterViewComponentTagHelper", TestCompilation.AssemblyName)
.TypeName("__Generated__StringParameterViewComponentTagHelper")
Expand All @@ -55,9 +56,9 @@ public class StringParameterViewComponent
.Build();

// Act
provider.Execute(context);
var result = service.GetTagHelpers(compilation);

// Assert
Assert.Single(context.Results, d => d.Equals(expectedDescriptor));
Assert.Single(result, d => d.Equals(expectedDescriptor));
}
}
17 changes: 9 additions & 8 deletions ...mponentTagHelperDescriptorProviderTest.cs → ...est/ViewComponentTagHelperProducerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X;

// This is just a basic integration test. There are detailed tests for the VCTH visitor and descriptor factory.
public class ViewComponentTagHelperDescriptorProviderTest
public class ViewComponentTagHelperProducerTest
{
[Fact]
public void DescriptorProvider_FindsVCTH()
Expand All @@ -24,12 +24,13 @@ public class StringParameterViewComponent

var compilation = MvcShim.BaseCompilation.AddSyntaxTrees(CSharpSyntaxTree.ParseText(code));

var context = new TagHelperDescriptorProviderContext(compilation);

var provider = new ViewComponentTagHelperDescriptorProvider()
var projectEngine = RazorProjectEngine.CreateEmpty(static b =>
{
Engine = RazorProjectEngine.CreateEmpty().Engine,
};
b.Features.Add(new ViewComponentTagHelperProducer.Factory());
b.Features.Add(new TagHelperDiscoveryService());
});

Assert.True(projectEngine.Engine.TryGetFeature(out ITagHelperDiscoveryService? service));

var expectedDescriptor = TagHelperDescriptorBuilder.CreateViewComponent("__Generated__StringParameterViewComponentTagHelper", TestCompilation.AssemblyName)
.TypeName("__Generated__StringParameterViewComponentTagHelper")
Expand All @@ -55,9 +56,9 @@ public class StringParameterViewComponent
.Build();

// Act
provider.Execute(context);
var result = service.GetTagHelpers(compilation);

// Assert
Assert.Single(context.Results, d => d.Equals(expectedDescriptor));
Assert.Single(result, d => d.Equals(expectedDescriptor));
}
}
17 changes: 9 additions & 8 deletions ...mponentTagHelperDescriptorProviderTest.cs → ...est/ViewComponentTagHelperProducerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Microsoft.AspNetCore.Mvc.Razor.Extensions;

// This is just a basic integration test. There are detailed tests for the VCTH visitor and descriptor factory.
public class ViewComponentTagHelperDescriptorProviderTest
public class ViewComponentTagHelperProducerTest
{
[Fact]
public void DescriptorProvider_FindsVCTH()
Expand All @@ -24,12 +24,13 @@ public class StringParameterViewComponent

var compilation = TestCompilation.Create().AddSyntaxTrees(CSharpSyntaxTree.ParseText(code));

var context = new TagHelperDescriptorProviderContext(compilation);

var provider = new ViewComponentTagHelperDescriptorProvider()
var projectEngine = RazorProjectEngine.CreateEmpty(static b =>
{
Engine = RazorProjectEngine.CreateEmpty().Engine,
};
b.Features.Add(new ViewComponentTagHelperProducer.Factory());
b.Features.Add(new TagHelperDiscoveryService());
});

Assert.True(projectEngine.Engine.TryGetFeature(out ITagHelperDiscoveryService? service));

var expectedDescriptor = TagHelperDescriptorBuilder.CreateViewComponent("__Generated__StringParameterViewComponentTagHelper", TestCompilation.AssemblyName)
.TypeName("__Generated__StringParameterViewComponentTagHelper")
Expand All @@ -55,9 +56,9 @@ public class StringParameterViewComponent
.Build();

// Act
provider.Execute(context);
var result = service.GetTagHelpers(compilation);

// Assert
Assert.Single(context.Results, d => d.Equals(expectedDescriptor));
Assert.Single(result, d => d.Equals(expectedDescriptor));
}
}
1 change: 1 addition & 0 deletions src/Compiler/Microsoft.AspNetCore.Razor.Language/test/RazorProjectEngineTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ private static void AssertDefaultFeatures(RazorProjectEngine engine)
feature => Assert.IsType<InheritsDirectivePass>(feature),
feature => Assert.IsType<MetadataAttributePass>(feature),
feature => Assert.IsType<PreallocatedTagHelperAttributeOptimizationPass>(feature),
feature => Assert.IsType<TagHelperDiscoveryService>(feature),
feature => Assert.IsType<ViewCssScopePass>(feature));
}

Expand Down
Loading