Skip to content

Remove 1.x tests #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ajaybhargavb merged 1 commit into from
Sep 25, 2019
Merged

Remove 1.x tests #1169

ajaybhargavb merged 1 commit into from
Sep 25, 2019

Conversation

@ajaybhargavb
Copy link
Contributor

@ajaybhargavb ajaybhargavb commented Sep 24, 2019

NTaylorMullen
NTaylorMullen approved these changes Sep 24, 2019
View reviewed changes
Copy link

@NTaylorMullen NTaylorMullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all passes gogogo. Btw, did this fix your issue on your box?

@ajaybhargavb
Copy link
Contributor Author

ajaybhargavb commented Sep 24, 2019

Btw, did this fix your issue on your box?

Nope.

@pranavkm
Copy link
Contributor

pranavkm commented Sep 25, 2019

@javiercn the Rebuild_Success_RecreatesManifestAndCache test failed here: https://dev.azure.com/dnceng/public/_build/results?buildId=365092&view=ms.vss-test-web.build-test-results-tab&runId=11042356&resultId=100194&paneView=debug.

@javiercn
Copy link
Member

javiercn commented Sep 25, 2019

@pranavkm Thanks! We have a dump! Posted the url https://github.com/aspnet/AspNetCore-Internal/issues/2613 I'll take a quck look.

@ajaybhargavb ajaybhargavb changed the base branch from master to release/3.1 September 25, 2019 17:16
@ajaybhargavb ajaybhargavb merged commit bd71bcf into release/3.1 Sep 25, 2019
@ghost ghost deleted the ajbaaska/nuke11 branch September 25, 2019 17:50
@ajaybhargavb ajaybhargavb mentioned this pull request Sep 25, 2019
Closed
ajaybhargavb added a commit that referenced this pull request Oct 11, 2019
@ajaybhargavb
Revert "Remove 1.x tests (#1169)"
5d0b560 
This reverts commit bd71bcf.
ajaybhargavb added a commit that referenced this pull request Feb 11, 2020
@ajaybhargavb
Revert "Remove 1.x tests (#1169)"
61b1896 
This reverts commit bd71bcf.
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request May 17, 2020
@ajaybhargavb
Remove 1.x tests (dotnet/razor#1169)
c05fca5 
\n\nCommit migrated from dotnet/razor@bd71bcf
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request May 17, 2020
@ajaybhargavb
Revert "Remove 1.x tests (dotnet/razor#1169)"
e4fb1d4 
This reverts commit dotnet/razor@bd71bcf.
\n\nCommit migrated from dotnet/razor@61b1896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pranavkm pranavkm Awaiting requested review from pranavkm

@rynowak rynowak Awaiting requested review from rynowak rynowak is a code owner

1 more reviewer

@NTaylorMullen NTaylorMullen NTaylorMullen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ajaybhargavb @pranavkm @javiercn @NTaylorMullen