-
Notifications
You must be signed in to change notification settings - Fork 233
Support netcoreapp3.1 TFM #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pilchie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though not sure about the pack exclusion.
src/Razor/test/Microsoft.NET.Sdk.Razor.Test/IntegrationTests/PackIntegrationTest.cs
Outdated
Show resolved
Hide resolved
|
Of the test failures: I don't know what this means.
|
|
@pranavkm I'm seeing the following failure RazorSdk_DoesNotBuildViewsForNetCoreApp11Projects: |
|
Could you skip it? .NET Core 1.0 \ 1.1 aren't in support any more, so we might be able to remove these tests without figuring out why they're failing so. |
|
cc @dougbu for review. |
src/Razor/test/Microsoft.NET.Sdk.Razor.Test/IntegrationTests/BuildIntegrationTest11.cs
Show resolved
Hide resolved
src/Razor/test/Microsoft.NET.Sdk.Razor.Test/IntegrationTests/PackIntegrationTest.cs
Show resolved
Hide resolved
* Support netcoreapp3.1 TFM * Update branding to preview1 * Skip failing 1.1 test \n\nCommit migrated from dotnet/razor@133b252
Addresses dotnet/aspnetcore#13581.